perf(regex): eliminate per-call clone overhead in preg_* dispatch

regex::Regex::clone() does not share the underlying meta engine's
search-cache pool, so every fresh clone pays a ~10us warmup cost on
its first use. Two changes together eliminate this across nearly all
preg_* call sites:

- A php_regex! macro resolves PHP-style patterns to a per-call-site
  &'static regex::Regex (via regex-macro's LazyLock), applied at the
  majority of call sites throughout the codebase.
- Call sites still passing dynamic pattern strings go through
  PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out
  Arc::clone()s instead of cloning the Regex itself.

PregPattern::resolve() returns a ResolvedPattern enum (Arc or
'static reference) rather than an owned Regex, so neither path ever
clones the Regex proper.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

3 files changed, 7 insertions, 6 deletions

diff --git a/crates/shirabe/src/package/archiver/archivable_files_finder.rs b/crates/shirabe/src/package/archiver/archivable_files_finder.rs
index 67f2fdaa..ad2b41ab 100644
--- a/crates/shirabe/src/package/archiver/archivable_files_finder.rs
+++ b/crates/shirabe/src/package/archiver/archivable_files_finder.rs
@@ -57,7 +57,7 @@ impl ArchivableFilesFinder {
             }
 
             let relative_path = Preg::replace(
-                &format!("#^{}#", preg_quote(&sources_clone, Some('#'))),
+                format!("#^{}#", preg_quote(&sources_clone, Some('#'))),
                 "",
                 &fs.normalize_path(&realpath.to_string_lossy()),
             );
diff --git a/crates/shirabe/src/package/archiver/archive_manager.rs b/crates/shirabe/src/package/archiver/archive_manager.rs
index eaeab9ce..52132be9 100644
--- a/crates/shirabe/src/package/archiver/archive_manager.rs
+++ b/crates/shirabe/src/package/archiver/archive_manager.rs
@@ -12,8 +12,8 @@ use crate::util::r#loop::Loop;
 use indexmap::IndexMap;
 use shirabe_external_packages::composer::pcre::Preg;
 use shirabe_php_shim::{
-    InvalidArgumentException, RuntimeException, bin2hex, file_exists, random_bytes, realpath,
-    sys_get_temp_dir,
+    InvalidArgumentException, RuntimeException, bin2hex, file_exists, php_regex, random_bytes,
+    realpath, sys_get_temp_dir,
 };
 
 pub struct ArchiveManager {
@@ -58,7 +58,7 @@ impl ArchiveManager {
     ) -> anyhow::Result<IndexMap<String, String>> {
         let base_name = match package.get_archive_name() {
             Some(name) => name.to_string(),
-            None => Preg::replace("#[^a-z0-9-_]#i", "-", &package.get_name()),
+            None => Preg::replace(php_regex!("#[^a-z0-9-_]#i"), "-", &package.get_name()),
         };
 
         let mut parts: IndexMap<String, String> = IndexMap::new();
@@ -66,7 +66,7 @@ impl ArchiveManager {
 
         let dist_reference = package.get_dist_reference();
         if let Some(ref dist_ref) = dist_reference {
-            if Preg::is_match("{^[a-f0-9]{40}$}", dist_ref) {
+            if Preg::is_match(php_regex!("{^[a-f0-9]{40}$}"), dist_ref) {
                 parts.insert("dist_reference".to_string(), dist_ref.to_string());
                 if let Some(dist_type) = package.get_dist_type() {
                     parts.insert("dist_type".to_string(), dist_type.to_string());
diff --git a/crates/shirabe/src/package/archiver/git_exclude_filter.rs b/crates/shirabe/src/package/archiver/git_exclude_filter.rs
index 8620bddc..85842411 100644
--- a/crates/shirabe/src/package/archiver/git_exclude_filter.rs
+++ b/crates/shirabe/src/package/archiver/git_exclude_filter.rs
@@ -3,6 +3,7 @@
 use crate::package::archiver::BaseExcludeFilter;
 use crate::package::archiver::BaseExcludeFilterBase;
 use shirabe_external_packages::composer::pcre::Preg;
+use shirabe_php_shim::php_regex;
 use std::path::Path;
 
 pub struct GitExcludeFilter {
@@ -35,7 +36,7 @@ impl GitExcludeFilter {
     }
 
     fn parse_git_attributes_line_static(line: &str) -> Option<(String, bool, bool)> {
-        let parts = Preg::split(r"#\s+#", line);
+        let parts = Preg::split(php_regex!(r"#\s+#"), line);
 
         if parts.len() == 2 && parts[1] == "export-ignore" {
             return Some(BaseExcludeFilterBase::generate_pattern(&parts[0]));