diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
| commit | a9f19862350c6fd3592d93515d869ffe07ecb399 (patch) | |
| tree | 3d2e97403d658476e9e42a1d179cd29b606240e2 /crates/shirabe/src/package/loader | |
| parent | c935842b0c0c2d2c62b3a718ebe0017b7b192318 (diff) | |
| download | php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.gz php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.zst php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.zip | |
feat: resolve trivial todo!() sites with existing constructors
Replace todo!("VersionParser::new()") with VersionParser::new() at 6
call sites (array_loader, base_command, create_project_command,
vcs_repository, http_downloader x2) and EventDispatcher::io_clone with
self.io.clone(). All targets already exist on their types.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/package/loader')
| -rw-r--r-- | crates/shirabe/src/package/loader/array_loader.rs | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/crates/shirabe/src/package/loader/array_loader.rs b/crates/shirabe/src/package/loader/array_loader.rs index 634bef8..744b40a 100644 --- a/crates/shirabe/src/package/loader/array_loader.rs +++ b/crates/shirabe/src/package/loader/array_loader.rs @@ -36,10 +36,7 @@ impl ArrayLoader { pub fn new(parser: Option<VersionParser>, load_options: bool) -> Self { let parser = match parser { Some(p) => p, - None => { - // TODO(phase-b): VersionParser has no public `new` yet - todo!("VersionParser::new()") - } + None => VersionParser::new(), }; Self { version_parser: parser, |