refactor(semver): change ConstraintInterface to a closed enum

Replace the dyn ConstraintInterface trait objects with an AnyConstraint
enum closing over its four implementors (Simple, Multi, MatchAll,
MatchNone), mirroring the earlier Rule enum conversion. Rename
constraint.rs to simple_constraint.rs to match the renamed Constraint
type.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2 files changed, 14 insertions, 12 deletions

diff --git a/crates/shirabe/src/package/loader/array_loader.rs b/crates/shirabe/src/package/loader/array_loader.rs
index ffbe465a..87d6e354 100644
--- a/crates/shirabe/src/package/loader/array_loader.rs
+++ b/crates/shirabe/src/package/loader/array_loader.rs
@@ -764,12 +764,10 @@ impl ArrayLoader {
             }
         };
 
-        // TODO(phase-b): Link::new expects Box<dyn ConstraintInterface>; we have Arc<dyn ConstraintInterface + Send + Sync>
-        let _ = parsed_constraint;
         Ok(Link::new(
             source.to_string(),
             target.to_string(),
-            todo!("phase-b: convert Arc<dyn ConstraintInterface> to Box<dyn ConstraintInterface>"),
+            parsed_constraint,
             Some(description.to_string()),
             Some(pretty_constraint.to_string()),
         ))
diff --git a/crates/shirabe/src/package/loader/validating_array_loader.rs b/crates/shirabe/src/package/loader/validating_array_loader.rs
index 59fc2663..a2dd5a76 100644
--- a/crates/shirabe/src/package/loader/validating_array_loader.rs
+++ b/crates/shirabe/src/package/loader/validating_array_loader.rs
@@ -11,9 +11,9 @@ use shirabe_php_shim::{
     is_string, json_encode, parse_url_all, php_to_string, sprintf, str_replace, strcasecmp,
     strtolower, strtotime, substr, trigger_error, trim, var_export,
 };
-use shirabe_semver::constraint::Constraint;
-use shirabe_semver::constraint::ConstraintInterface;
+use shirabe_semver::constraint::AnyConstraint;
 use shirabe_semver::constraint::MatchNoneConstraint;
+use shirabe_semver::constraint::SimpleConstraint;
 use shirabe_semver::intervals::Intervals;
 
 use crate::package::loader::InvalidPackageException;
@@ -877,7 +877,8 @@ impl ValidatingArrayLoader {
             }
         }
 
-        let unbound_constraint = Constraint::new("=", "10000000-dev");
+        let unbound_constraint =
+            SimpleConstraint::new("=".to_string(), "10000000-dev".to_string(), None).into();
 
         let link_types: Vec<&'static str> = SUPPORTED_LINK_TYPES.keys().copied().collect();
         for link_type in link_types {
@@ -952,11 +953,14 @@ impl ValidatingArrayLoader {
                         } else if (self.flags & Self::CHECK_STRICT_CONSTRAINTS) != 0
                             && link_type == "require"
                             && link_constraint
-                                .as_any()
-                                .downcast_ref::<Constraint>()
+                                .as_constraint()
                                 .map_or(false, |c| ["==", "="].contains(&c.get_operator()))
-                            && Constraint::new(">=", "1.0.0.0-dev")
-                                .matches(link_constraint.as_ref())
+                            && AnyConstraint::from(SimpleConstraint::new(
+                                ">=".to_string(),
+                                "1.0.0.0-dev".to_string(),
+                                None,
+                            ))
+                            .matches(&link_constraint)
                         {
                             self.warnings.push(format!(
                                 "{}.{} : exact version constraints ({}) should be avoided if the package follows semantic versioning",
@@ -964,8 +968,8 @@ impl ValidatingArrayLoader {
                             ));
                         }
 
-                        let compacted = Intervals::compact_constraint(link_constraint.as_ref())?;
-                        if compacted.as_any().is::<MatchNoneConstraint>() {
+                        let compacted = Intervals::compact_constraint(&link_constraint)?;
+                        if compacted.is_match_none() {
                             self.warnings.push(format!(
                                 "{}.{} : this version constraint cannot possibly match anything ({})",
                                 link_type, package, constraint_str