aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/package/version
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-20 23:37:42 +0900
committernsfisis <nsfisis@gmail.com>2026-06-20 23:37:42 +0900
commit84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d (patch)
tree189f8ce5d7d53246632d5e2419c392d58f06e2b8 /crates/shirabe/src/package/version
parent10840ec1fd7f1140305449fc94175d60998572c1 (diff)
downloadphp-shirabe-84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d.tar.gz
php-shirabe-84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d.tar.zst
php-shirabe-84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d.zip
feat(symfony-process): port full Process class from PHP
Faithfully port every method, field and constant of Symfony's Process.php into process.rs, replacing the reduced stub. Add the supporting pipes module (PipesInterface/AbstractPipes/UnixPipes/ WindowsPipes), ProcessUtils and the missing process exceptions (LogicException/InvalidArgumentException) with constructors. Methods now return anyhow::Result where PHP throws, take the env argument and a bool-returning callback, and borrow &mut for status-updating accessors; all callers are updated accordingly. Extend the php-shim with proc_open/proc_close (PHP-compatible signatures), proc_get_status, proc_terminate, posix_kill, uniqid, ftruncate, ftell_stream, fseek3, stream_get_contents3 and env helpers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/package/version')
-rw-r--r--crates/shirabe/src/package/version/version_guesser.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/src/package/version/version_guesser.rs b/crates/shirabe/src/package/version/version_guesser.rs
index 42646cb..7f0625f 100644
--- a/crates/shirabe/src/package/version/version_guesser.rs
+++ b/crates/shirabe/src/package/version/version_guesser.rs
@@ -533,14 +533,14 @@ impl VersionGuesser {
},
&scm_cmdline,
);
- let process = tokio::runtime::Runtime::new()
+ let mut process = tokio::runtime::Runtime::new()
.unwrap()
.block_on(self.process.borrow_mut().execute_async(&cmd_line, path))?;
if !process.is_successful() {
continue;
}
- let output = process.get_output();
+ let output = process.get_output()?;
// overwrite existing if we have a shorter diff, or we have an equal diff and an index that comes later in the array (i.e. older version)
// as newer versions typically have more commits, if the feature branch is based on a newer branch it should have a longer diff to the old version
// but if it doesn't and they have equal diffs, then it probably is based on the old version