diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-04 02:25:28 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-04 05:43:18 +0900 |
| commit | a02fc7d728a9973a3275a0f47604081c4439b424 (patch) | |
| tree | b1a73d2eb6b17bb6c204318b58d75ae6cf46cc7a /crates/shirabe/src/plugin.rs | |
| parent | 20f7a7826ae048d249e0d837ca6393a5f09c9ba6 (diff) | |
| download | php-shirabe-a02fc7d728a9973a3275a0f47604081c4439b424.tar.gz php-shirabe-a02fc7d728a9973a3275a0f47604081c4439b424.tar.zst php-shirabe-a02fc7d728a9973a3275a0f47604081c4439b424.zip | |
feat(plugin): activate plugins through the PHP RPC worker
Implement the remainder of PluginManager::registerPackage: the plugin
autoload map is built by the ported createLoader/parseAutoloads and
served to the worker over the existing reverse-RPC autoloader, files
entries go through a composerRequire-equivalent glue call, and
already-defined classes take the upstream _composer_tmp rename/eval
path. Instantiation uses the new NewObject/CallPhpMethod lanes backed
by a P table in the worker; PhpPluginProxy adapts the resulting handle
to PluginInterface, with $composer/$io exposed to plugin callbacks via
an R table (unsupported methods stay explicit errors). Hand-written
proxy stubs cover Composer, PartialComposer and the IO hierarchy, and
the stub autoloader is re-prepended after loading the Composer PHP
runtime so its vendor autoloader cannot shadow proxied FQCNs.
FilesystemRepository::write now mirrors InstalledVersions::reload into
a running worker (class_exists-guarded, so an unloaded class keeps its
upstream lazy-load behavior), removing the previously undefined
observation window.
The installer pipeline passes the installed repository as a shared
handle instead of a long-lived `&mut dyn`: plugin registration runs
inside InstallationManager::execute and re-enters the same local
repository through the RepositoryManager, which would panic on the
RefCell re-borrow under the old shape.
PluginInterface lifecycle methods now take an owned ComposerHandle
(plugins retain $composer past the call) and return anyhow::Result
(PHP plugin code may throw); the plugin list uses shared ownership so
the identity comparison of removePlugin survives the dual storage in
registeredPlugins, matching PHP reference semantics.
Ports the activate/upgrade/uninstall tests of PluginInstallerTest,
serialized across the shared worker process whose persistent class
table is exactly what exercises the rename path.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/plugin.rs')
| -rw-r--r-- | crates/shirabe/src/plugin.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/crates/shirabe/src/plugin.rs b/crates/shirabe/src/plugin.rs index a26e1173..a629e4c0 100644 --- a/crates/shirabe/src/plugin.rs +++ b/crates/shirabe/src/plugin.rs @@ -1,6 +1,7 @@ pub mod capability; pub mod capable; pub mod command_event; +pub mod php_plugin_proxy; pub mod plugin_blocked_exception; pub mod plugin_events; pub mod plugin_interface; @@ -13,6 +14,7 @@ pub mod pre_pool_create_event; pub use capability::*; pub use capable::*; pub use command_event::*; +pub use php_plugin_proxy::*; pub use plugin_blocked_exception::*; pub use plugin_events::*; pub use plugin_interface::*; |