aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/plugin
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
committernsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
commit6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 (patch)
treee39261f4aa7314fe8c75142670c76591cdaccb92 /crates/shirabe/src/plugin
parent5d3232a80be4b989e89cc7ae4e3642cc5acae030 (diff)
downloadphp-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.gz
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.zst
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.zip
feat(console): resolve phase-b TODOs in doRun and IO wiring
Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/plugin')
-rw-r--r--crates/shirabe/src/plugin/plugin_manager.rs13
1 files changed, 9 insertions, 4 deletions
diff --git a/crates/shirabe/src/plugin/plugin_manager.rs b/crates/shirabe/src/plugin/plugin_manager.rs
index 9dcf754..24899cd 100644
--- a/crates/shirabe/src/plugin/plugin_manager.rs
+++ b/crates/shirabe/src/plugin/plugin_manager.rs
@@ -920,15 +920,20 @@ impl PluginManager {
"allow-plugins",
PhpMixed::Array(allow_plugins.clone()),
)?;
- // TODO(phase-b): get_config() returns &Config, but merge needs &mut Config; ownership needs refactoring
let mut inner: IndexMap<String, Box<PhpMixed>> = IndexMap::new();
inner.insert(
"allow-plugins".to_string(),
Box::new(PhpMixed::Array(allow_plugins)),
);
- let mut wrap: IndexMap<String, PhpMixed> = IndexMap::new();
- wrap.insert("config".to_string(), PhpMixed::Array(inner));
- todo!("see TODO(phase-b) above");
+ let mut config_section: IndexMap<String, Box<PhpMixed>> =
+ IndexMap::new();
+ config_section
+ .insert("config".to_string(), Box::new(PhpMixed::Array(inner)));
+ let wrap: IndexMap<String, PhpMixed> =
+ config_section.into_iter().map(|(k, v)| (k, *v)).collect();
+ config
+ .borrow_mut()
+ .merge(&wrap, crate::config::Config::SOURCE_UNKNOWN);
}
}