diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-25 19:10:47 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-25 22:00:09 +0900 |
| commit | 53f4444c5ac9cc1c14749afb7ba2c3ccd1929889 (patch) | |
| tree | 1d62c4e69a698008e131743b30c57304984113ff /crates/shirabe/src/repository/advisory_provider_interface.rs | |
| parent | 432472808051cb4f1bb9517b858dbc810aaa5a63 (diff) | |
| download | php-shirabe-53f4444c5ac9cc1c14749afb7ba2c3ccd1929889.tar.gz php-shirabe-53f4444c5ac9cc1c14749afb7ba2c3ccd1929889.tar.zst php-shirabe-53f4444c5ac9cc1c14749afb7ba2c3ccd1929889.zip | |
perf(advisory): share AnySecurityAdvisory via Rc
PHP's SecurityAdvisoryPoolFilter stores advisory *object references* in
$securityRemovedVersions, and PoolOptimizer::applyRemovalsToPool hands
that array to the new Pool by copy-on-write. Porting AnySecurityAdvisory
as a value type turned both of those into deep copies.
Measured on `require laravel/framework` (offline, warm cache): 113
distinct advisories were duplicated into 314,309 copies of ~1.08 KiB,
retaining 331.9 MiB in the filter loop and another 331.9 MiB when
apply_removals_to_pool cloned the whole map.
3.54s -> 2.62s (-26%), peak RSS 975 MB -> 343 MB, which matches the upper
bound measured by ablation. Composer runs the same workload in 1.49s.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/repository/advisory_provider_interface.rs')
| -rw-r--r-- | crates/shirabe/src/repository/advisory_provider_interface.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/shirabe/src/repository/advisory_provider_interface.rs b/crates/shirabe/src/repository/advisory_provider_interface.rs index f1e639a1..466093c1 100644 --- a/crates/shirabe/src/repository/advisory_provider_interface.rs +++ b/crates/shirabe/src/repository/advisory_provider_interface.rs @@ -7,7 +7,7 @@ use shirabe_semver::constraint::AnyConstraint; #[derive(Debug)] pub struct SecurityAdvisoryResult { pub names_found: Vec<String>, - pub advisories: IndexMap<String, Vec<AnySecurityAdvisory>>, + pub advisories: IndexMap<String, Vec<std::rc::Rc<AnySecurityAdvisory>>>, } pub trait AdvisoryProviderInterface { |