diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-06 18:21:02 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-06 18:21:02 +0900 |
| commit | 23f8a0dc3e08949ec78e050b7642c605fa2aaaf5 (patch) | |
| tree | 2633604624cb53695dfdc4d9597ff1d034c57eac /crates/shirabe/src/repository/composite_repository.rs | |
| parent | d5b313f388d424e60ae33ae58c1a65a65b24b8f1 (diff) | |
| download | php-shirabe-23f8a0dc3e08949ec78e050b7642c605fa2aaaf5.tar.gz php-shirabe-23f8a0dc3e08949ec78e050b7642c605fa2aaaf5.tar.zst php-shirabe-23f8a0dc3e08949ec78e050b7642c605fa2aaaf5.zip | |
feat(composite-repository): forward remove_package to writable repos
Resolve the phase-b TODO by adding an as_writable_repository_interface_mut
downcast helper on RepositoryInterface, mirroring PHP's instanceof
WritableRepositoryInterface check, and propagate inner errors.
Diffstat (limited to 'crates/shirabe/src/repository/composite_repository.rs')
| -rw-r--r-- | crates/shirabe/src/repository/composite_repository.rs | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/crates/shirabe/src/repository/composite_repository.rs b/crates/shirabe/src/repository/composite_repository.rs index 78bbc6a..97fad44 100644 --- a/crates/shirabe/src/repository/composite_repository.rs +++ b/crates/shirabe/src/repository/composite_repository.rs @@ -32,12 +32,16 @@ impl CompositeRepository { &self.repositories } - pub fn remove_package(&mut self, _package: PackageInterfaceHandle) { - // TODO(phase-b): only call remove_package on WritableRepositoryInterface implementors; - // requires a downcast helper such as `as_writable() -> Option<&mut dyn WritableRepositoryInterface>` on RepositoryInterface. - for _repository in &mut self.repositories { - todo!() + pub fn remove_package(&mut self, package: PackageInterfaceHandle) -> anyhow::Result<()> { + for repository in &self.repositories { + if let Some(writable) = repository + .borrow_mut() + .as_writable_repository_interface_mut() + { + writable.remove_package(package.clone())?; + } } + Ok(()) } pub fn add_repository(&mut self, repository: RepositoryInterfaceHandle) { |
