aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/repository/installed_array_repository.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-05-25 00:58:20 +0900
committernsfisis <nsfisis@gmail.com>2026-05-25 00:58:36 +0900
commit1921f173ea219cb4b25847294d2d3fa465550fbb (patch)
tree0d30486a2cb9a0c106e5d5827be3f655c60cd871 /crates/shirabe/src/repository/installed_array_repository.rs
parentdbdecaf5a1c54a876b7ee0153d58dd39b1080f97 (diff)
downloadphp-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.tar.gz
php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.tar.zst
php-shirabe-1921f173ea219cb4b25847294d2d3fa465550fbb.zip
refactor(package): introduce Rc<RefCell<_>> handles for packages
PHP packages have reference semantics, so introduce shared-ownership handles over an AnyPackage enum (PackageInterfaceHandle and friends) and replace Box<dyn PackageInterface> throughout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/repository/installed_array_repository.rs')
-rw-r--r--crates/shirabe/src/repository/installed_array_repository.rs17
1 files changed, 9 insertions, 8 deletions
diff --git a/crates/shirabe/src/repository/installed_array_repository.rs b/crates/shirabe/src/repository/installed_array_repository.rs
index b089df6..f0244b6 100644
--- a/crates/shirabe/src/repository/installed_array_repository.rs
+++ b/crates/shirabe/src/repository/installed_array_repository.rs
@@ -4,8 +4,9 @@ use indexmap::IndexMap;
use shirabe_php_shim::Countable;
use shirabe_semver::constraint::AnyConstraint;
-use crate::package::BasePackage;
+use crate::package::BasePackageHandle;
use crate::package::PackageInterface;
+use crate::package::PackageInterfaceHandle;
use crate::repository::AdvisoryProviderInterface;
use crate::repository::InstalledRepositoryInterface;
use crate::repository::WritableArrayRepository;
@@ -24,7 +25,7 @@ impl InstalledArrayRepository {
Self::new_with_packages(Vec::new())
}
- pub fn new_with_packages(packages: Vec<Box<dyn PackageInterface>>) -> anyhow::Result<Self> {
+ pub fn new_with_packages(packages: Vec<PackageInterfaceHandle>) -> anyhow::Result<Self> {
Ok(Self {
inner: WritableArrayRepository::new(packages)?,
})
@@ -56,7 +57,7 @@ impl WritableRepositoryInterface for InstalledArrayRepository {
fn add_package(
&mut self,
- package: Box<dyn crate::package::PackageInterface>,
+ package: crate::package::PackageInterfaceHandle,
) -> anyhow::Result<()> {
todo!()
}
@@ -68,7 +69,7 @@ impl WritableRepositoryInterface for InstalledArrayRepository {
todo!()
}
- fn get_canonical_packages(&self) -> Vec<Box<dyn crate::package::PackageInterface>> {
+ fn get_canonical_packages(&self) -> Vec<crate::package::PackageInterfaceHandle> {
todo!()
}
@@ -99,17 +100,17 @@ impl RepositoryInterface for InstalledArrayRepository {
&self,
_name: &str,
_constraint: FindPackageConstraint,
- ) -> Option<Box<dyn BasePackage>> {
+ ) -> Option<BasePackageHandle> {
todo!()
}
fn find_packages(
&self,
_name: &str,
_constraint: Option<FindPackageConstraint>,
- ) -> Vec<Box<dyn BasePackage>> {
+ ) -> Vec<BasePackageHandle> {
todo!()
}
- fn get_packages(&self) -> Vec<Box<dyn BasePackage>> {
+ fn get_packages(&self) -> Vec<BasePackageHandle> {
todo!()
}
fn load_packages(
@@ -117,7 +118,7 @@ impl RepositoryInterface for InstalledArrayRepository {
_package_name_map: IndexMap<String, Option<AnyConstraint>>,
_acceptable_stabilities: IndexMap<String, i64>,
_stability_flags: IndexMap<String, i64>,
- _already_loaded: IndexMap<String, IndexMap<String, Box<dyn PackageInterface>>>,
+ _already_loaded: IndexMap<String, IndexMap<String, PackageInterfaceHandle>>,
) -> LoadPackagesResult {
todo!()
}