fix(repository): run lazy initialization in count/has_package

PHP's ArrayRepository::count()/hasPackage() call $this->initialize(),
which late-binds to the concrete repository class and lazily loads its
packages. The Rust pass-throughs skipped that: they ran ArrayRepository's
stub initialize instead, returning 0/false and marking the repository
initialized with an empty package list, which made ensure_initialized()
skip the real initialization forever after.

Take &mut self in RepositoryInterface::count/has_package so the lazy
repositories (Filesystem, Platform, Composer) can guard with their real
initialize, and return Result from has_package since that initialization
can fail (PHP propagates the exception). InstallerInterface::is_installed
and InstallationManager::is_package_installed/mark_alias_installed
propagate the same way, which also resolves the TODO(phase-d) markers on
Package/Path/Artifact/Vcs repositories about initialization errors being
swallowed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

1 files changed, 6 insertions, 2 deletions

diff --git a/crates/shirabe/src/repository/repository_interface.rs b/crates/shirabe/src/repository/repository_interface.rs
index 6dbc01da..ab25242c 100644
--- a/crates/shirabe/src/repository/repository_interface.rs
+++ b/crates/shirabe/src/repository/repository_interface.rs
@@ -52,9 +52,13 @@ pub const SEARCH_NAME: i64 = 1;
 pub const SEARCH_VENDOR: i64 = 2;
 
 pub trait RepositoryInterface: std::fmt::Debug {
-    fn count(&self) -> anyhow::Result<usize>;
+    // count/has_package take &mut self (and has_package returns Result) because PHP's
+    // ArrayRepository::count()/hasPackage() late-bind $this->initialize() to the concrete
+    // repository class, which lazily loads packages and can throw; lazy repositories need the
+    // same guard here (see FilesystemRepository/PlatformRepository/ComposerRepository).
+    fn count(&mut self) -> anyhow::Result<usize>;
 
-    fn has_package(&self, package: PackageInterfaceHandle) -> bool;
+    fn has_package(&mut self, package: PackageInterfaceHandle) -> anyhow::Result<bool>;
 
     fn find_package(
         &mut self,