refactor(http-response): take url directly instead of request map

Response only ever reads the url out of the request array, so accept it
as a String directly. With url always present the 'url key missing'
LogicException can no longer fire, so Response::new and CurlResponse::new
return Self instead of a double Result. Also drops the unused
from_php_mixed/to_php_mixed stubs and the request_to_map helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 2 insertions, 8 deletions

diff --git a/crates/shirabe/src/repository/vcs/forgejo_driver.rs b/crates/shirabe/src/repository/vcs/forgejo_driver.rs
index ca7e9dd..30a0932 100644
--- a/crates/shirabe/src/repository/vcs/forgejo_driver.rs
+++ b/crates/shirabe/src/repository/vcs/forgejo_driver.rs
@@ -625,17 +625,11 @@ impl ForgejoDriver {
                             })?;
 
                         return Ok(Response::new(
-                            {
-                                let mut m = IndexMap::new();
-                                m.insert("url".to_string(), PhpMixed::String("dummy".to_string()));
-                                m
-                            },
+                            "dummy".to_string(),
                             Some(200),
                             vec![],
                             Some("null".to_string()),
-                        )
-                        .unwrap()
-                        .unwrap());
+                        ));
                     }
 
                     if !self.inner.io.has_authentication(&self.inner.origin_url) {