fix(git-bitbucket-driver): match PHP exception/fallibility semantics for fallback paths

VcsDriverInterface::get_source/get_dist were made fallible in the Rust
port even though PHP's are infallible, forcing GitBitbucketDriver's
fallback delegation to silently swallow errors via
unwrap_or_default()/ok().flatten(). Make the trait infallible to match
PHP, updating the mechanical Ok(...) wrapping in all implementors.

Also narrow attempt_clone_fallback's cleanup to only trigger on
RuntimeException, mirroring PHP's catch (\RuntimeException $e), using
the same downcast pattern already used by has_composer_file for
TransportException.

1 files changed, 6 insertions, 6 deletions

diff --git a/crates/shirabe/src/repository/vcs/github_driver.rs b/crates/shirabe/src/repository/vcs/github_driver.rs
index d68bf4e..3ee38f2 100644
--- a/crates/shirabe/src/repository/vcs/github_driver.rs
+++ b/crates/shirabe/src/repository/vcs/github_driver.rs
@@ -1350,19 +1350,19 @@ impl crate::repository::vcs::VcsDriverInterface for GitHubDriver {
         GitHubDriver::get_tags(self)
     }
 
-    fn get_dist(&self, identifier: &str) -> anyhow::Result<Option<IndexMap<String, String>>> {
-        Ok(GitHubDriver::get_dist(self, identifier).map(|m| {
+    fn get_dist(&self, identifier: &str) -> Option<IndexMap<String, String>> {
+        GitHubDriver::get_dist(self, identifier).map(|m| {
             m.into_iter()
                 .map(|(k, v)| (k, v.as_string().unwrap_or("").to_string()))
                 .collect()
-        }))
+        })
     }
 
-    fn get_source(&self, identifier: &str) -> anyhow::Result<IndexMap<String, String>> {
-        Ok(GitHubDriver::get_source(self, identifier)
+    fn get_source(&self, identifier: &str) -> IndexMap<String, String> {
+        GitHubDriver::get_source(self, identifier)
             .into_iter()
             .map(|(k, v)| (k, v.as_string().unwrap_or("").to_string()))
-            .collect())
+            .collect()
     }
 
     fn get_url(&self) -> String {