aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/repository/vcs/gitlab_driver.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-05 18:09:25 +0900
committernsfisis <nsfisis@gmail.com>2026-07-05 18:09:25 +0900
commit8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0 (patch)
tree4e589da29ead636082aeaaff4c674fd60227dcea /crates/shirabe/src/repository/vcs/gitlab_driver.rs
parenta666f969ff42578ce583c481fb6093673203a924 (diff)
downloadphp-shirabe-8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0.tar.gz
php-shirabe-8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0.tar.zst
php-shirabe-8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0.zip
fix(git-bitbucket-driver): match PHP exception/fallibility semantics for fallback paths
VcsDriverInterface::get_source/get_dist were made fallible in the Rust port even though PHP's are infallible, forcing GitBitbucketDriver's fallback delegation to silently swallow errors via unwrap_or_default()/ok().flatten(). Make the trait infallible to match PHP, updating the mechanical Ok(...) wrapping in all implementors. Also narrow attempt_clone_fallback's cleanup to only trigger on RuntimeException, mirroring PHP's catch (\RuntimeException $e), using the same downcast pattern already used by has_composer_file for TransportException.
Diffstat (limited to 'crates/shirabe/src/repository/vcs/gitlab_driver.rs')
-rw-r--r--crates/shirabe/src/repository/vcs/gitlab_driver.rs12
1 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe/src/repository/vcs/gitlab_driver.rs b/crates/shirabe/src/repository/vcs/gitlab_driver.rs
index 3f66223..4ad75b6 100644
--- a/crates/shirabe/src/repository/vcs/gitlab_driver.rs
+++ b/crates/shirabe/src/repository/vcs/gitlab_driver.rs
@@ -1156,19 +1156,19 @@ impl crate::repository::vcs::VcsDriverInterface for GitLabDriver {
GitLabDriver::get_tags(self)
}
- fn get_dist(&self, identifier: &str) -> anyhow::Result<Option<IndexMap<String, String>>> {
- Ok(GitLabDriver::get_dist(self, identifier).map(|m| {
+ fn get_dist(&self, identifier: &str) -> Option<IndexMap<String, String>> {
+ GitLabDriver::get_dist(self, identifier).map(|m| {
m.into_iter()
.map(|(k, v)| (k, v.as_string().unwrap_or("").to_string()))
.collect()
- }))
+ })
}
- fn get_source(&self, identifier: &str) -> anyhow::Result<IndexMap<String, String>> {
- Ok(GitLabDriver::get_source(self, identifier)
+ fn get_source(&self, identifier: &str) -> IndexMap<String, String> {
+ GitLabDriver::get_source(self, identifier)
.into_iter()
.map(|(k, v)| (k, v.as_string().unwrap_or("").to_string()))
- .collect())
+ .collect()
}
fn get_url(&self) -> String {