feat(downloader,repository): wire exception instanceof downcasts via anyhow

Resolve the PHP try/catch instanceof checks that select on exception type:
TransportException-only catches in RepositorySet, SvnDriver and JsonFile;
the RuntimeException/IrrecoverableDownloadException handleError closure and
the RuntimeException update-retry catch in DownloadManager. Each uses
anyhow::Error::downcast_ref and reads the exception's message field directly
(Display is todo\!() on the shim exceptions). PHPUnit\Framework\Exception
checks in VcsDownloader are documented as intentionally always-false since
the test framework is out of scope.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 9 insertions, 3 deletions

diff --git a/crates/shirabe/src/repository/vcs/svn_driver.rs b/crates/shirabe/src/repository/vcs/svn_driver.rs
index a793340..2812c8d 100644
--- a/crates/shirabe/src/repository/vcs/svn_driver.rs
+++ b/crates/shirabe/src/repository/vcs/svn_driver.rs
@@ -184,9 +184,15 @@ impl SvnDriver {
             let composer: Option<IndexMap<String, PhpMixed>> = match base_result {
                 Ok(c) => c,
                 Err(e) => {
-                    // TODO(phase-b): downcast to TransportException
-                    let _te: &TransportException = todo!("downcast e to TransportException");
-                    let message = e.to_string();
+                    // PHP catches only TransportException; other exceptions propagate uncaught.
+                    if e.downcast_ref::<TransportException>().is_none() {
+                        return Err(e);
+                    }
+                    let message = e
+                        .downcast_ref::<TransportException>()
+                        .unwrap()
+                        .message
+                        .clone();
                     if stripos(&message, "path not found").is_none()
                         && stripos(&message, "svn: warning: W160013").is_none()
                     {