aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/repository/vcs_repository.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-05 18:09:25 +0900
committernsfisis <nsfisis@gmail.com>2026-07-05 18:09:25 +0900
commit8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0 (patch)
tree4e589da29ead636082aeaaff4c674fd60227dcea /crates/shirabe/src/repository/vcs_repository.rs
parenta666f969ff42578ce583c481fb6093673203a924 (diff)
downloadphp-shirabe-8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0.tar.gz
php-shirabe-8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0.tar.zst
php-shirabe-8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0.zip
fix(git-bitbucket-driver): match PHP exception/fallibility semantics for fallback paths
VcsDriverInterface::get_source/get_dist were made fallible in the Rust port even though PHP's are infallible, forcing GitBitbucketDriver's fallback delegation to silently swallow errors via unwrap_or_default()/ok().flatten(). Make the trait infallible to match PHP, updating the mechanical Ok(...) wrapping in all implementors. Also narrow attempt_clone_fallback's cleanup to only trigger on RuntimeException, mirroring PHP's catch (\RuntimeException $e), using the same downcast pattern already used by has_composer_file for TransportException.
Diffstat (limited to 'crates/shirabe/src/repository/vcs_repository.rs')
-rw-r--r--crates/shirabe/src/repository/vcs_repository.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs
index 8d747c6..6a31c78 100644
--- a/crates/shirabe/src/repository/vcs_repository.rs
+++ b/crates/shirabe/src/repository/vcs_repository.rs
@@ -869,7 +869,7 @@ impl VcsRepository {
);
if !data.contains_key("dist") {
- let dist = driver.get_dist(identifier)?;
+ let dist = driver.get_dist(identifier);
data.insert(
"dist".to_string(),
match dist {
@@ -883,7 +883,7 @@ impl VcsRepository {
);
}
if !data.contains_key("source") {
- let source = driver.get_source(identifier)?;
+ let source = driver.get_source(identifier);
data.insert(
"source".to_string(),
PhpMixed::Array(