aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/repository
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
committernsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
commit5ab5f3b316798c1411ce8e6a7f5b091fda93589c (patch)
treec7669f94f5d9bd9adc07bc1aab3f14cfdec1ae5f /crates/shirabe/src/repository
parentb291e714bc739262140323e08fe2fb9e91e00ee7 (diff)
downloadphp-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.gz
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.zst
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.zip
test: port previously-ignored Composer tests via __ test hatches
Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/repository')
-rw-r--r--crates/shirabe/src/repository/artifact_repository.rs9
-rw-r--r--crates/shirabe/src/repository/path_repository.rs26
-rw-r--r--crates/shirabe/src/repository/repository_manager.rs6
3 files changed, 41 insertions, 0 deletions
diff --git a/crates/shirabe/src/repository/artifact_repository.rs b/crates/shirabe/src/repository/artifact_repository.rs
index b913edb..9a28d65 100644
--- a/crates/shirabe/src/repository/artifact_repository.rs
+++ b/crates/shirabe/src/repository/artifact_repository.rs
@@ -65,6 +65,15 @@ impl ArtifactRepository {
format!("artifact repo ({})", self.lookup)
}
+ /// For testing only: drives `initialize` (scanning the lookup directory) and returns the
+ /// packages collected by the inner `ArrayRepository`, mirroring the polymorphic
+ /// `RepositoryInterface::getPackages` dispatch in PHP.
+ pub fn __get_packages(&mut self) -> anyhow::Result<Vec<crate::package::BasePackageHandle>> {
+ self.initialize()?;
+ use crate::repository::RepositoryInterface;
+ self.inner.get_packages()
+ }
+
fn initialize(&mut self) -> anyhow::Result<()> {
self.inner.initialize();
let lookup = self.lookup.clone();
diff --git a/crates/shirabe/src/repository/path_repository.rs b/crates/shirabe/src/repository/path_repository.rs
index 4508460..b8c106a 100644
--- a/crates/shirabe/src/repository/path_repository.rs
+++ b/crates/shirabe/src/repository/path_repository.rs
@@ -113,6 +113,32 @@ impl PathRepository {
)
}
+ /// For testing only: drives `initialize` (globbing the configured url and loading each
+ /// path package) and returns the packages collected by the inner `ArrayRepository`,
+ /// mirroring the polymorphic `RepositoryInterface::getPackages` dispatch in PHP.
+ pub fn __get_packages(&mut self) -> anyhow::Result<Vec<crate::package::BasePackageHandle>> {
+ self.initialize()?;
+ use crate::repository::RepositoryInterface;
+ self.inner.get_packages()
+ }
+
+ /// For testing only: returns `RepositoryInterface::count` after `initialize`.
+ pub fn __count(&mut self) -> anyhow::Result<usize> {
+ self.initialize()?;
+ use crate::repository::RepositoryInterface;
+ self.inner.count()
+ }
+
+ /// For testing only: returns `RepositoryInterface::has_package` after `initialize`.
+ pub fn __has_package(
+ &mut self,
+ package: crate::package::PackageInterfaceHandle,
+ ) -> anyhow::Result<bool> {
+ self.initialize()?;
+ use crate::repository::RepositoryInterface;
+ Ok(self.inner.has_package(package))
+ }
+
pub(crate) fn initialize(&mut self) -> anyhow::Result<()> {
self.inner.initialize();
diff --git a/crates/shirabe/src/repository/repository_manager.rs b/crates/shirabe/src/repository/repository_manager.rs
index 69684e2..403b504 100644
--- a/crates/shirabe/src/repository/repository_manager.rs
+++ b/crates/shirabe/src/repository/repository_manager.rs
@@ -162,6 +162,12 @@ impl RepositoryManager {
&self.repositories
}
+ /// For testing only: exposes the private `repository_classes` map so tests
+ /// can assert on its registered type keys (PHP reads it via ReflectionProperty).
+ pub fn __repository_classes(&self) -> &IndexMap<String, String> {
+ &self.repository_classes
+ }
+
pub fn set_local_repository(&mut self, repository: RepositoryInterfaceHandle) {
self.local_repository = Some(repository);
}