diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
| commit | a9f19862350c6fd3592d93515d869ffe07ecb399 (patch) | |
| tree | 3d2e97403d658476e9e42a1d179cd29b606240e2 /crates/shirabe/src/util/http_downloader.rs | |
| parent | c935842b0c0c2d2c62b3a718ebe0017b7b192318 (diff) | |
| download | php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.gz php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.zst php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.zip | |
feat: resolve trivial todo!() sites with existing constructors
Replace todo!("VersionParser::new()") with VersionParser::new() at 6
call sites (array_loader, base_command, create_project_command,
vcs_repository, http_downloader x2) and EventDispatcher::io_clone with
self.io.clone(). All targets already exist on their types.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/util/http_downloader.rs')
| -rw-r--r-- | crates/shirabe/src/util/http_downloader.rs | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/crates/shirabe/src/util/http_downloader.rs b/crates/shirabe/src/util/http_downloader.rs index 89bf0a4..b33ed58 100644 --- a/crates/shirabe/src/util/http_downloader.rs +++ b/crates/shirabe/src/util/http_downloader.rs @@ -712,8 +712,7 @@ impl HttpDownloader { let versions_key = format!("{}-versions", r#type); if let Some(versions_value) = data.get(&versions_key) { if !shirabe_php_shim::empty(versions_value) { - // TODO(phase-b): VersionParser::new - let version_parser: VersionParser = todo!("VersionParser::new()"); + let version_parser: VersionParser = VersionParser::new(); let constraint = version_parser .parse_constraints(versions_value.as_string().unwrap_or(""))?; let composer_constraint = SimpleConstraint::new( @@ -745,8 +744,7 @@ impl HttpDownloader { continue; } - // TODO(phase-b): VersionParser::new - let version_parser: VersionParser = todo!("VersionParser::new()"); + let version_parser: VersionParser = VersionParser::new(); if let Some(PhpMixed::List(list)) = entry { for spec in list { let r#type = substr(key, 0, Some(-1)); |
