refactor: replace literal-list in_array_strict with matches!

Call sites whose haystack was an inline array of literals (or a local
built solely to feed one) had to wrap both sides in PhpMixed just to
compare, allocating a String per element on every call. matches! does
the same test against the underlying &str/i64/Option directly, so the
PhpMixed round trip and its .to_string()/.clone()/.iter().map()
conversions are gone.

Sites whose haystack is a runtime value or a named constant array are
left on in_array_strict: inlining a named constant would duplicate its
contents at the call site.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1 files changed, 6 insertions, 10 deletions

diff --git a/crates/shirabe/src/util/platform.rs b/crates/shirabe/src/util/platform.rs
index 9ebf4f4f..a71fea92 100644
--- a/crates/shirabe/src/util/platform.rs
+++ b/crates/shirabe/src/util/platform.rs
@@ -5,10 +5,9 @@ use crate::util::Silencer;
 use shirabe_external_packages::composer::pcre::Preg;
 use shirabe_php_shim::{
     PHP_ENV, PHP_SERVER, PhpMixed, PhpResource, RuntimeException, defined, file_exists,
-    file_get_contents, fstat, function_exists, getcwd, getenv, in_array_strict, ini_get, is_array,
-    is_readable, mb_strlen, php_os_family, php_regex, posix_geteuid, posix_getpwuid, posix_getuid,
-    posix_isatty, putenv, putenv_clear, realpath, stream_isatty, stripos, strlen, strtoupper,
-    substr, usleep,
+    file_get_contents, fstat, function_exists, getcwd, getenv, ini_get, is_array, is_readable,
+    mb_strlen, php_os_family, php_regex, posix_geteuid, posix_getpwuid, posix_getuid, posix_isatty,
+    putenv, putenv_clear, realpath, stream_isatty, stripos, strlen, strtoupper, substr, usleep,
 };
 use std::sync::Mutex;
 
@@ -280,12 +279,9 @@ impl Platform {
 
         // detect msysgit/mingw and assume this is a tty because detection
         // does not work correctly, see https://github.com/composer/composer/issues/9690
-        if in_array_strict(
-            strtoupper(&Self::get_env("MSYSTEM").unwrap_or_default()),
-            &[
-                PhpMixed::String("MINGW32".to_string()),
-                PhpMixed::String("MINGW64".to_string()),
-            ],
+        if matches!(
+            strtoupper(&Self::get_env("MSYSTEM").unwrap_or_default()).as_str(),
+            "MINGW32" | "MINGW64"
         ) {
             return true;
         }