diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:41:34 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:46:18 +0900 |
| commit | 2d474e91e49c7343d28198eff2b5bbbed9afbcee (patch) | |
| tree | 8c1ab321dfa5ddc1ca9d2871eb06a6fde6b2970b /crates/shirabe/src/util/remote_filesystem.rs | |
| parent | e583112899cbea7494ffdd73d7de380dd5f808c4 (diff) | |
| download | php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.gz php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.zst php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.zip | |
feat(phase-c): resolve cross-module phase-b TODOs
Diffstat (limited to 'crates/shirabe/src/util/remote_filesystem.rs')
| -rw-r--r-- | crates/shirabe/src/util/remote_filesystem.rs | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/crates/shirabe/src/util/remote_filesystem.rs b/crates/shirabe/src/util/remote_filesystem.rs index bd4aaa8..dc6a2a4 100644 --- a/crates/shirabe/src/util/remote_filesystem.rs +++ b/crates/shirabe/src/util/remote_filesystem.rs @@ -720,7 +720,8 @@ impl RemoteFilesystem { } let mut caught_e: Option<anyhow::Error> = None; - // TODO(phase-b): wrap PHP's `file_get_contents` with stream context and error capture. + // TODO(phase-c): wrap PHP's `file_get_contents` with stream context and error capture; + // depends on the unmodeled PHP stream-context layer. let outer: Result<Option<String>, anyhow::Error> = Ok(None); match outer { Ok(v) => result = v, @@ -743,7 +744,8 @@ impl RemoteFilesystem { *response_headers = http_get_last_response_headers().unwrap_or_default(); http_clear_last_response_headers(); } else { - // TODO(phase-b): read the magic `$http_response_header` PHP variable. + // TODO(phase-c): read the magic `$http_response_header` PHP variable; depends on the + // unmodeled PHP stream layer that populates it. *response_headers = Vec::new(); } |
