aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/util/svn.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
committernsfisis <nsfisis@gmail.com>2026-06-11 02:39:35 +0900
commit6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83 (patch)
treee39261f4aa7314fe8c75142670c76591cdaccb92 /crates/shirabe/src/util/svn.rs
parent5d3232a80be4b989e89cc7ae4e3642cc5acae030 (diff)
downloadphp-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.gz
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.tar.zst
php-shirabe-6ae7e0d4b3eaf20e2d2cd3d000cf61ab0c9b6e83.zip
feat(console): resolve phase-b TODOs in doRun and IO wiring
Wire up ConsoleIO with HelperSet/QuestionHelper, register the ErrorHandler with the IO instance, and fall back to a default output in run(). Replace resolved phase-b TODOs across the console, command, io, factory, installer, dependency_resolver, and util modules; reclassify the remaining blockers (typed Symfony command registry, stdin resource caching) as phase-c. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/util/svn.rs')
-rw-r--r--crates/shirabe/src/util/svn.rs11
1 files changed, 9 insertions, 2 deletions
diff --git a/crates/shirabe/src/util/svn.rs b/crates/shirabe/src/util/svn.rs
index 7634b62..8453a43 100644
--- a/crates/shirabe/src/util/svn.rs
+++ b/crates/shirabe/src/util/svn.rs
@@ -140,7 +140,13 @@ impl Svn {
let command = self.get_command(svn_command.clone(), url, path);
let mut output: Option<String> = None;
- // TODO(phase-b): handler captures &mut output and io by reference; restructure for Rust closures
+ // PHP: $handler = function ($type, $buffer) use (&$output, $io, $verbose) { ... };
+ // $status = $this->process->execute($command, $handler, $cwd);
+ // TODO(phase-c): ProcessExecutor::execute does not yet accept a streaming output callback
+ // (its Symfony Process backing stays todo!()), so this handler — which filters by stream
+ // type, drops "Redirecting to URL" lines, accumulates into `output`, and echoes when
+ // verbose — cannot be passed through. The plain-buffer execute_args call below loses that
+ // filtering; resolving needs the process callback model (cf. process_executor.rs).
let _io = &self.io;
let _handler = |r#type: &str, buffer: &str| -> Option<()> {
if r#type != "out" {
@@ -156,7 +162,8 @@ impl Svn {
}
None
};
- // TODO(phase-b): pass handler callback to process.execute
+ // TODO(phase-c): pass the filtering handler above to process.execute once the callback
+ // model lands; for now a plain buffer is used and the output filtering is skipped.
let mut handler_output = String::new();
let status = self.process.borrow_mut().execute_args(
&command,