aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/util/tls_helper.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-18 15:03:55 +0900
committernsfisis <nsfisis@gmail.com>2026-07-18 15:54:27 +0900
commit91692846909ed191addb7ec1c34aad11392ab88b (patch)
tree7c477055e432fd43a98e5dddc016e07dcfc67f60 /crates/shirabe/src/util/tls_helper.rs
parent4ae58baf8618f5fe916ba2a69faaca93514134ce (diff)
downloadphp-shirabe-91692846909ed191addb7ec1c34aad11392ab88b.tar.gz
php-shirabe-91692846909ed191addb7ec1c34aad11392ab88b.tar.zst
php-shirabe-91692846909ed191addb7ec1c34aad11392ab88b.zip
perf(regex): eliminate per-call clone overhead in preg_* dispatch
regex::Regex::clone() does not share the underlying meta engine's search-cache pool, so every fresh clone pays a ~10us warmup cost on its first use. Two changes together eliminate this across nearly all preg_* call sites: - A php_regex! macro resolves PHP-style patterns to a per-call-site &'static regex::Regex (via regex-macro's LazyLock), applied at the majority of call sites throughout the codebase. - Call sites still passing dynamic pattern strings go through PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out Arc::clone()s instead of cloning the Regex itself. PregPattern::resolve() returns a ResolvedPattern enum (Arc or 'static reference) rather than an owned Regex, so neither path ever clones the Regex proper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/util/tls_helper.rs')
-rw-r--r--crates/shirabe/src/util/tls_helper.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/src/util/tls_helper.rs b/crates/shirabe/src/util/tls_helper.rs
index 6422be3e..5121bd06 100644
--- a/crates/shirabe/src/util/tls_helper.rs
+++ b/crates/shirabe/src/util/tls_helper.rs
@@ -3,7 +3,7 @@
use shirabe_external_packages::composer::ca_bundle::ca_bundle::CaBundle;
use shirabe_external_packages::composer::pcre::Preg;
use shirabe_php_shim::{
- PhpMixed, ltrim, preg_quote, str_replace, strtolower, substr, substr_count,
+ PhpMixed, ltrim, php_regex, preg_quote, str_replace, strtolower, substr, substr_count,
};
/// Extracted certificate names. Mirrors PHP's `array{cn: string, san: string[]}`.
@@ -81,7 +81,7 @@ impl TlsHelper {
.and_then(|e| e.get("subjectAltName"))
.and_then(|s| s.as_string())
{
- let split = Preg::split("{\\s*,\\s*}", san);
+ let split = Preg::split(php_regex!("{\\s*,\\s*}"), san);
subject_alt_names = split
.into_iter()
.filter_map(|name| {