diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-24 20:23:24 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-24 20:23:24 +0900 |
| commit | 7392662eed92f00b41e173809fb51f6a21572003 (patch) | |
| tree | 8593c85b071fe49d3b1793d12330a540da83ccc2 /crates/shirabe/src | |
| parent | 70198f0c1e67594549193413fb8e86b1879dc41d (diff) | |
| download | php-shirabe-7392662eed92f00b41e173809fb51f6a21572003.tar.gz php-shirabe-7392662eed92f00b41e173809fb51f6a21572003.tar.zst php-shirabe-7392662eed92f00b41e173809fb51f6a21572003.zip | |
fix(solver-problems): preserve first-occurrence order in extension hint
create_extension_hint's --ignore-platform-req suggestion list sorted
missing extensions alphabetically before deduping. PHP's array_unique
removes duplicates while preserving first-occurrence order instead,
which for this call site matches the order problems were reported in
(root-require-not-found problems before SAT-conflict problems).
Replaced the sort+dedup with the existing order-preserving
shirabe_php_shim::array_unique, which was already ported for exactly
this PHP semantic but wasn't used here.
Diffstat (limited to 'crates/shirabe/src')
| -rw-r--r-- | crates/shirabe/src/dependency_resolver/solver_problems_exception.rs | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/crates/shirabe/src/dependency_resolver/solver_problems_exception.rs b/crates/shirabe/src/dependency_resolver/solver_problems_exception.rs index 48fe76b3..39f2b2c1 100644 --- a/crates/shirabe/src/dependency_resolver/solver_problems_exception.rs +++ b/crates/shirabe/src/dependency_resolver/solver_problems_exception.rs @@ -134,9 +134,7 @@ impl SolverProblemsException { paths.remove(0); } - let mut unique_extensions: Vec<String> = missing_extensions.to_vec(); - unique_extensions.sort(); - unique_extensions.dedup(); + let unique_extensions = shirabe_php_shim::array_unique(missing_extensions); let ignore_extensions_arguments: String = unique_extensions .iter() .map(|ext| format!("--ignore-platform-req={}", ext)) |
