diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:07:47 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:07:47 +0900 |
| commit | c935842b0c0c2d2c62b3a718ebe0017b7b192318 (patch) | |
| tree | ad83bb7fc8d128790260e12ebbe25915b70e375c /crates/shirabe/src | |
| parent | 8181f57ec3428195ac822590257cb3c135e25b5d (diff) | |
| download | php-shirabe-c935842b0c0c2d2c62b3a718ebe0017b7b192318.tar.gz php-shirabe-c935842b0c0c2d2c62b3a718ebe0017b7b192318.tar.zst php-shirabe-c935842b0c0c2d2c62b3a718ebe0017b7b192318.zip | |
refactor: drop stale phase-b TODO comments resolved by current code
These TODOs describe work already done: writeError per-line iteration
(github, remote_filesystem, svn_downloader) and reference equality via
std::ptr::eq (download_manager). No behavior change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src')
| -rw-r--r-- | crates/shirabe/src/downloader/download_manager.rs | 1 | ||||
| -rw-r--r-- | crates/shirabe/src/downloader/svn_downloader.rs | 3 | ||||
| -rw-r--r-- | crates/shirabe/src/util/github.rs | 1 | ||||
| -rw-r--r-- | crates/shirabe/src/util/remote_filesystem.rs | 3 |
4 files changed, 0 insertions, 8 deletions
diff --git a/crates/shirabe/src/downloader/download_manager.rs b/crates/shirabe/src/downloader/download_manager.rs index b230ae3..7d5d76d 100644 --- a/crates/shirabe/src/downloader/download_manager.rs +++ b/crates/shirabe/src/downloader/download_manager.rs @@ -174,7 +174,6 @@ impl DownloadManager { pub fn get_downloader_type(&self, downloader: &dyn DownloaderInterface) -> String { // PHP: array_search($downloader, $this->downloaders) - // TODO(phase-b): reference equality on Box<dyn DownloaderInterface> for (r#type, candidate) in &self.downloaders { if std::ptr::eq( candidate.as_ref() as *const dyn DownloaderInterface as *const (), diff --git a/crates/shirabe/src/downloader/svn_downloader.rs b/crates/shirabe/src/downloader/svn_downloader.rs index 8ac3e99..1e00c03 100644 --- a/crates/shirabe/src/downloader/svn_downloader.rs +++ b/crates/shirabe/src/downloader/svn_downloader.rs @@ -229,7 +229,6 @@ impl SvnDownloader { io_interface::NORMAL, ); let slice_end = 10_usize.min(changes.len()); - // TODO(phase-b): PHP writeError accepts array<string>; iterate per-line for now. for line in &changes[..slice_end] { self.inner.io.write_error3(line, true, io_interface::NORMAL); } @@ -268,13 +267,11 @@ impl SvnDownloader { .into()); } Some("v") => { - // TODO(phase-b): PHP writeError accepts array<string>; iterate per-line. for line in &changes { self.inner.io.write_error3(line, true, io_interface::NORMAL); } } _ => { - // TODO(phase-b): PHP writeError accepts array<string>; iterate per-line. let help_lines = vec