aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/all_functional_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-28 23:10:43 +0900
committernsfisis <nsfisis@gmail.com>2026-06-28 23:10:43 +0900
commit1a85368838c1e482f2a7020ff1cbdc87fcb092cc (patch)
tree6c89ebc81f401abc1af8116eebb10905697d6649 /crates/shirabe/tests/all_functional_test.rs
parent1e72ee3ddaf581753e30b39dfc33b48d44a25ef7 (diff)
downloadphp-shirabe-1a85368838c1e482f2a7020ff1cbdc87fcb092cc.tar.gz
php-shirabe-1a85368838c1e482f2a7020ff1cbdc87fcb092cc.tar.zst
php-shirabe-1a85368838c1e482f2a7020ff1cbdc87fcb092cc.zip
fix(installer): execute install/update/uninstall ops in execute_batch
execute_batch only awaited prepare(), leaving the install/update/ uninstall + cleanup + repo.write promise chain as a todo!() stub, so packages were downloaded to cache but never installed into the target directory. Wire the operation step (mirroring PHP's promise chain), propagate errors from the install/update/uninstall wrappers instead of swallowing them with .ok()?, and write the repo after each op. Un-ignore the create-project functional tests and the install/remove command tests this unblocks. The remaining --no-install case still fails on a separate install-path bug; its ignore reason is updated to match.
Diffstat (limited to 'crates/shirabe/tests/all_functional_test.rs')
-rw-r--r--crates/shirabe/tests/all_functional_test.rs2
1 files changed, 0 insertions, 2 deletions
diff --git a/crates/shirabe/tests/all_functional_test.rs b/crates/shirabe/tests/all_functional_test.rs
index bc2e4ee..531aa78 100644
--- a/crates/shirabe/tests/all_functional_test.rs
+++ b/crates/shirabe/tests/all_functional_test.rs
@@ -255,14 +255,12 @@ fn test_build_phar() {
#[test]
#[serial]
-#[ignore = "requires network access and a real git clone of seld/jsonlint from GitHub/Packagist"]
fn test_integration_create_project_command() {
run_integration("create-project-command.test");
}
#[test]
#[serial]
-#[ignore = "requires network access and a real git clone of seld/jsonlint from GitHub"]
fn test_integration_create_project_shows_full_hash_for_dev_packages() {
run_integration("create-project-shows-full-hash-for-dev-packages.test");
}