diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-05 19:27:56 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-05 19:27:56 +0900 |
| commit | 325bb3ca3789843304424c7d552d0d3bb8d39ea2 (patch) | |
| tree | 7772f62eb8b82cbdbf8a228107f9bed3e5067408 /crates/shirabe/tests/command/global_command_test.rs | |
| parent | 3f7865faae3eb93c5c258320ebfb99855cbdeb97 (diff) | |
| download | php-shirabe-325bb3ca3789843304424c7d552d0d3bb8d39ea2.tar.gz php-shirabe-325bb3ca3789843304424c7d552d0d3bb8d39ea2.tar.zst php-shirabe-325bb3ca3789843304424c7d552d0d3bb8d39ea2.zip | |
feat(global-command): wire resetComposer and Application::run proxying
Application::find/reset_composer and the shared ApplicationHandle are
now available, so GlobalCommand can reset the composer instance before
building the sub-command input and proxy execution through the full
Application::run dispatch, matching PHP's behavior. Un-ignores the
tests that only depended on this wiring, and re-points the remaining
ignores at their real (unrelated) blockers.
Diffstat (limited to 'crates/shirabe/tests/command/global_command_test.rs')
| -rw-r--r-- | crates/shirabe/tests/command/global_command_test.rs | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/crates/shirabe/tests/command/global_command_test.rs b/crates/shirabe/tests/command/global_command_test.rs index 4d99613..5f0efd0 100644 --- a/crates/shirabe/tests/command/global_command_test.rs +++ b/crates/shirabe/tests/command/global_command_test.rs @@ -31,7 +31,7 @@ fn chdir_unique_tmp_directory() -> TempDir { #[test] #[serial] -#[ignore = "GlobalCommand::run proxies to Application::run via todo!() at crates/shirabe/src/command/global_command.rs:190 (pending shared Application handle)"] +#[ignore = "runs a composer.json script, which Application::do_run registers as a reflection-instantiated command; that registration path is todo!() at crates/shirabe/src/console/application.rs:2461 (plugin: register reflection-instantiated command on Application::add)"] fn test_global() { let _env_guard = EnvGuard; @@ -120,7 +120,6 @@ fn test_cannot_create_home() { #[test] #[serial] -#[ignore = "GlobalCommand::run proxies to Application::run via todo!() at crates/shirabe/src/command/global_command.rs:190 (pending shared Application handle)"] fn test_global_show() { let _env_guard = EnvGuard; @@ -171,7 +170,6 @@ fn test_global_show() { #[test] #[serial] -#[ignore = "GlobalCommand::run proxies to Application::run via todo!() at crates/shirabe/src/command/global_command.rs:190 (pending shared Application handle)"] fn test_global_show_without_packages() { let _env_guard = EnvGuard; @@ -203,7 +201,7 @@ fn test_global_show_without_packages() { #[test] #[serial] -#[ignore = "GlobalCommand::run proxies to Application::run via todo!() at crates/shirabe/src/command/global_command.rs:190 (pending shared Application handle)"] +#[ignore = "installs a package via the global command's require sub-dispatch, which panics inside the event dispatcher: \"Subscriber ?::? for event pre-operations-exec is not callable\""] fn test_global_require() { let _env_guard = EnvGuard; @@ -262,7 +260,6 @@ fn test_global_require() { #[test] #[serial] -#[ignore = "GlobalCommand::run proxies to Application::run via todo!() at crates/shirabe/src/command/global_command.rs:190 (pending shared Application handle)"] fn test_global_update() { let _env_guard = EnvGuard; @@ -313,7 +310,6 @@ fn test_global_update() { #[test] #[serial] -#[ignore = "GlobalCommand::run proxies to Application::run via todo!() at crates/shirabe/src/command/global_command.rs:190 (pending shared Application handle)"] fn test_global_changes_directory() { let _env_guard = EnvGuard; |
