diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-25 23:25:25 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-25 23:25:25 +0900 |
| commit | 3c39377b0c419dd4cc792aef926032b15c12b69f (patch) | |
| tree | 59d10e9a13d71727ccee0b6356ad8dd5f6ddfb55 /crates/shirabe/tests/command/require_command_test.rs | |
| parent | 47b81add8dc5e8d53ed1c8507c2791d0dd6a5929 (diff) | |
| download | php-shirabe-3c39377b0c419dd4cc792aef926032b15c12b69f.tar.gz php-shirabe-3c39377b0c419dd4cc792aef926032b15c12b69f.tar.zst php-shirabe-3c39377b0c419dd4cc792aef926032b15c12b69f.zip | |
fix(package-discovery): pass IO so platform requirement warnings surface
findBestVersionForPackage is the only findBestCandidate() caller that PHP hands
$this->getIO() to; the port passed None, so VersionSelector silently skipped
every "Cannot use <pkg> as it requires <ext> which is missing from your
platform" warning. require/update/create-project therefore dropped a candidate
without telling the user why.
Un-ignores require_command_test::test_require, whose first data-provider case
asserts exactly that warning.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/command/require_command_test.rs')
| -rw-r--r-- | crates/shirabe/tests/command/require_command_test.rs | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/crates/shirabe/tests/command/require_command_test.rs b/crates/shirabe/tests/command/require_command_test.rs index bf742ea1..2ab3989b 100644 --- a/crates/shirabe/tests/command/require_command_test.rs +++ b/crates/shirabe/tests/command/require_command_test.rs @@ -266,11 +266,6 @@ Using version 1.1.0 for required/pkg", #[test] #[serial] -#[ignore = "the pre-operations-exec listener bug is fixed; now fails on the first data-provider \ - case ('warn once for missing ext but a lower package matches') because the \ - \"<warning>Cannot use required/pkg's latest version 1.2.0 as it requires ext-foobar \ - ^1 which is missing from your platform.</warning>\" message is never emitted — a \ - distinct, unimplemented require_command warning path unrelated to event dispatching"] fn test_require() { for (label, composer_json, command, expected) in provide_require() { let _tear_down = init_temp_composer(Some(&composer_json), None, None, true); |
