aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/command/require_command_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-18 01:07:23 +0900
committernsfisis <nsfisis@gmail.com>2026-07-18 01:07:23 +0900
commitdee7a8ad1ba80eafee746a6af2bfec578ca60d4e (patch)
tree56d6feedff136712c1203bfd00f12b01644052f5 /crates/shirabe/tests/command/require_command_test.rs
parentd1960a8b7488dffe161080714447120fa6f85db1 (diff)
downloadphp-shirabe-dee7a8ad1ba80eafee746a6af2bfec578ca60d4e.tar.gz
php-shirabe-dee7a8ad1ba80eafee746a6af2bfec578ca60d4e.tar.zst
php-shirabe-dee7a8ad1ba80eafee746a6af2bfec578ca60d4e.zip
fix(require-command): avoid unsupported regex lookahead in dev-branch check
The `regex` crate does not support negative lookahead, so the ported `^dev-(?!main$|master$|trunk$|latest$)` pattern panicked at runtime on any `require` invocation that reached version-selection. Replace it with equivalent hand-written string logic per docs/dev/regex-porting.md.
Diffstat (limited to 'crates/shirabe/tests/command/require_command_test.rs')
-rw-r--r--crates/shirabe/tests/command/require_command_test.rs4
1 files changed, 0 insertions, 4 deletions
diff --git a/crates/shirabe/tests/command/require_command_test.rs b/crates/shirabe/tests/command/require_command_test.rs
index e6186505..b132eb43 100644
--- a/crates/shirabe/tests/command/require_command_test.rs
+++ b/crates/shirabe/tests/command/require_command_test.rs
@@ -340,10 +340,6 @@ fn provide_inconsistent_require_keys() -> Vec<(bool, bool, &'static str)> {
#[test]
#[serial]
-#[ignore = "the solver-pool root-package issue is fixed; now panics in shirabe_php_shim::preg \
- (\"look-around, including look-ahead and look-behind, is not supported\") because \
- the dev-branch pattern `^dev-(?!main$|master$|trunk$|latest$)` uses a lookahead the \
- `regex` crate cannot express (see docs/dev/regex-porting.md)"]
fn test_inconsistent_require_keys() {
for (is_dev, is_interactive, expected_warning) in provide_inconsistent_require_keys() {
let current_key = if is_dev { "require" } else { "require-dev" };