refactor: fix compiler warnings and clippy warnings

7 files changed, 33 insertions, 25 deletions

diff --git a/crates/shirabe/tests/command/base_dependency_command_test.rs b/crates/shirabe/tests/command/base_dependency_command_test.rs
index 697face..41ad362 100644
--- a/crates/shirabe/tests/command/base_dependency_command_test.rs
+++ b/crates/shirabe/tests/command/base_dependency_command_test.rs
@@ -263,8 +263,8 @@ fn test_warning_when_dependencies_are_not_installed() {
         let some_dev_required_package = get_package("vendor2/package1", "1.0.0");
 
         create_composer_lock(
-            &[some_required_package.clone()],
-            &[some_dev_required_package.clone()],
+            std::slice::from_ref(&some_required_package),
+            std::slice::from_ref(&some_dev_required_package),
         );
 
         let mut input: Vec<(PhpMixed, PhpMixed)> =
@@ -403,7 +403,7 @@ fn test_why_command_outputs() {
                 second_required_package.clone(),
                 third_required_package.clone(),
             ],
-            &[some_dev_required_package.clone()],
+            std::slice::from_ref(&some_dev_required_package),
         );
         create_installed_json(
             &[
@@ -411,7 +411,7 @@ fn test_why_command_outputs() {
                 second_required_package.clone(),
                 third_required_package.clone(),
             ],
-            &[some_dev_required_package.clone()],
+            std::slice::from_ref(&some_dev_required_package),
             true,
         );
 
@@ -571,14 +571,14 @@ fn test_why_not_command_outputs() {
         let second_dev_nested_required_package = get_package("vendor2/package3", "1.4.0");
 
         create_composer_lock(
-            &[some_required_package.clone()],
+            std::slice::from_ref(&some_required_package),
             &[
                 first_dev_required_package.clone(),
                 second_dev_required_package.clone(),
             ],
         );
         create_installed_json(
-            &[some_required_package.clone()],
+            std::slice::from_ref(&some_required_package),
             &[
                 first_dev_required_package.clone(),
                 second_dev_required_package.clone(),
diff --git a/crates/shirabe/tests/command/global_command_test.rs b/crates/shirabe/tests/command/global_command_test.rs
index 6eec017..4d99613 100644
--- a/crates/shirabe/tests/command/global_command_test.rs
+++ b/crates/shirabe/tests/command/global_command_test.rs
@@ -287,7 +287,7 @@ fn test_global_update() {
     let composer_home_str = tear_down.working_dir().to_string_lossy().to_string();
 
     let pkg = get_package("vendor/pkg", "1.0.0");
-    create_installed_json(&[pkg.clone()], &[], true);
+    create_installed_json(std::slice::from_ref(&pkg), &[], true);
     create_composer_lock(&[pkg], &[]);
 
     Platform::put_env("COMPOSER_HOME", &composer_home_str);
diff --git a/crates/shirabe/tests/command/init_command_test.rs b/crates/shirabe/tests/command/init_command_test.rs
index f8d3e26..efb3f49 100644
--- a/crates/shirabe/tests/command/init_command_test.rs
+++ b/crates/shirabe/tests/command/init_command_test.rs
@@ -602,7 +602,7 @@ fn test_format_authors() {
 fn test_get_git_config() {
     set_up();
 
-    let mut command = InitCommand::new();
+    let command = InitCommand::new();
     let git_config = command.__get_git_config();
     assert!(git_config.contains_key("user.name"));
     assert!(git_config.contains_key("user.email"));
diff --git a/crates/shirabe/tests/command/licenses_command_test.rs b/crates/shirabe/tests/command/licenses_command_test.rs
index 05bd7f6..5b25aad 100644
--- a/crates/shirabe/tests/command/licenses_command_test.rs
+++ b/crates/shirabe/tests/command/licenses_command_test.rs
@@ -190,7 +190,7 @@ fn test_format_summary() {
         .unwrap();
     assert_eq!(0, status_code);
 
-    let expected = vec![
+    let expected = [
         ("-", "-"),
         ("License", "Number of dependencies"),
         ("-", "-"),
diff --git a/crates/shirabe/tests/command/remove_command_test.rs b/crates/shirabe/tests/command/remove_command_test.rs
index f645cc0..a27976a 100644
--- a/crates/shirabe/tests/command/remove_command_test.rs
+++ b/crates/shirabe/tests/command/remove_command_test.rs
@@ -282,7 +282,7 @@ fn test_remove_unused_package() {
     let required_package = get_package("root/req", "1.0.0");
     let extraneous_package = get_package("not/req", "1.0.0");
 
-    create_installed_json(&[required_package.clone()], &[], true);
+    create_installed_json(std::slice::from_ref(&required_package), &[], true);
     create_composer_lock(&[required_package.clone(), extraneous_package.clone()], &[]);
 
     let mut app_tester = get_application_tester();
@@ -825,8 +825,8 @@ fn test_package_still_present_error_when_no_install_flag_used() {
     );
     let root_req_package = get_package("root/req", "1.0.0");
 
-    create_installed_json(&[root_req_package.clone()], &[], true);
-    create_composer_lock(&[root_req_package.clone()], &[]);
+    create_installed_json(std::slice::from_ref(&root_req_package), &[], true);
+    create_composer_lock(std::slice::from_ref(&root_req_package), &[]);
 
     let mut app_tester = get_application_tester();
     let status_code = app_tester
@@ -915,8 +915,8 @@ fn run_update_inherited_dependencies_flag_case(
     let root_req_package = get_package("root/req", "1.0.0");
     root_req_package.__set_type("metapackage".to_string());
 
-    create_installed_json(&[root_req_package.clone()], &[], true);
-    create_composer_lock(&[root_req_package.clone()], &[]);
+    create_installed_json(std::slice::from_ref(&root_req_package), &[], true);
+    create_composer_lock(std::slice::from_ref(&root_req_package), &[]);
 
     let mut app_tester = get_application_tester();
     let status_code = app_tester
diff --git a/crates/shirabe/tests/command/show_command_test.rs b/crates/shirabe/tests/command/show_command_test.rs
index a73992d..d5f0828 100644
--- a/crates/shirabe/tests/command/show_command_test.rs
+++ b/crates/shirabe/tests/command/show_command_test.rs
@@ -1218,7 +1218,7 @@ fn run_not_existing_package_case(package: &str, options: Vec<(&str, PhpMixed)>,
         true,
     );
     let pkg = get_package("vendor/package", "1.0.0");
-    create_installed_json(&[pkg.clone()], &[], true);
+    create_installed_json(std::slice::from_ref(&pkg), &[], true);
     create_composer_lock(&[pkg], &[]);
 
     let mut pairs = vec![
diff --git a/crates/shirabe/tests/command/suggests_command_test.rs b/crates/shirabe/tests/command/suggests_command_test.rs
index 8bbb950..e6732dc 100644
--- a/crates/shirabe/tests/command/suggests_command_test.rs
+++ b/crates/shirabe/tests/command/suggests_command_test.rs
@@ -237,14 +237,14 @@ vendor2/package2 suggests:
     // 'with lockfile, show suggested (excluding dev)'
     run_suggest_case(
         true,
-        &[no_dev.clone()],
+        std::slice::from_ref(&no_dev),
         "vendor1/package1 suggests:
  - vendor3/suggested: helpful for vendor1/package1
 
 1 additional suggestions by transitive dependencies can be shown with --all",
     );
     // 'without lockfile, show suggested (excluding dev)'
-    run_suggest_case(false, &[no_dev.clone()], basic);
+    run_suggest_case(false, std::slice::from_ref(&no_dev), basic);
 
     let all_suggested = "vendor1/package1 suggests:
  - vendor3/suggested: helpful for vendor1/package1
@@ -257,8 +257,8 @@ vendor5/dev-package suggests:
 
 vendor6/package6 suggests:
  - vendor7/transitive: helpful for vendor6/package6";
-    run_suggest_case(true, &[all.clone()], all_suggested);
-    run_suggest_case(false, &[all.clone()], all_suggested);
+    run_suggest_case(true, std::slice::from_ref(&all), all_suggested);
+    run_suggest_case(false, std::slice::from_ref(&all), all_suggested);
 
     // 'with lockfile, show all suggested (excluding dev)'
     run_suggest_case(
@@ -273,8 +273,8 @@ vendor6/package6 suggests:
     run_suggest_case(false, &[all.clone(), no_dev.clone()], all_suggested);
 
     // grouped by package
-    run_suggest_case(true, &[by_package.clone()], basic);
-    run_suggest_case(false, &[by_package.clone()], basic);
+    run_suggest_case(true, std::slice::from_ref(&by_package), basic);
+    run_suggest_case(false, std::slice::from_ref(&by_package), basic);
     run_suggest_case(
         true,
         &[by_package.clone(), no_dev.clone()],
@@ -293,8 +293,16 @@ vendor4/dev-suggested is suggested by:
  - vendor2/package2: helpful for vendor2/package2
 
 2 additional suggestions by transitive dependencies can be shown with --all";
-    run_suggest_case(true, &[by_suggestion.clone()], by_suggestion_out);
-    run_suggest_case(false, &[by_suggestion.clone()], by_suggestion_out);
+    run_suggest_case(
+        true,
+        std::slice::from_ref(&by_suggestion),
+        by_suggestion_out,
+    );
+    run_suggest_case(
+        false,
+        std::slice::from_ref(&by_suggestion),
+        by_suggestion_out,
+    );
     run_suggest_case(
         true,
         &[by_suggestion.clone(), no_dev.clone()],
@@ -367,8 +375,8 @@ vendor3/suggested is suggested by:
     // list suggested
     let list_out = "vendor3/suggested
 vendor4/dev-suggested";
-    run_suggest_case(true, &[list.clone()], list_out);
-    run_suggest_case(false, &[list.clone()], list_out);
+    run_suggest_case(true, std::slice::from_ref(&list), list_out);
+    run_suggest_case(false, std::slice::from_ref(&list), list_out);
     run_suggest_case(true, &[list.clone(), no_dev.clone()], "vendor3/suggested");
     run_suggest_case(false, &[list.clone(), no_dev.clone()], list_out);