aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/command
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
committernsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
commit37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch)
treeb19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/command
parent80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff)
downloadphp-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/command')
-rw-r--r--crates/shirabe/tests/command/base_dependency_command_test.rs3
-rw-r--r--crates/shirabe/tests/command/check_platform_reqs_command_test.rs1
-rw-r--r--crates/shirabe/tests/command/install_command_test.rs4
-rw-r--r--crates/shirabe/tests/command/remove_command_test.rs9
-rw-r--r--crates/shirabe/tests/command/show_command_test.rs8
-rw-r--r--crates/shirabe/tests/command/suggests_command_test.rs2
-rw-r--r--crates/shirabe/tests/command/update_command_test.rs1
7 files changed, 0 insertions, 28 deletions
diff --git a/crates/shirabe/tests/command/base_dependency_command_test.rs b/crates/shirabe/tests/command/base_dependency_command_test.rs
index 30de8432..41ad362d 100644
--- a/crates/shirabe/tests/command/base_dependency_command_test.rs
+++ b/crates/shirabe/tests/command/base_dependency_command_test.rs
@@ -117,7 +117,6 @@ fn test_exception_when_running_locked_without_lock_file() {
/// ref: BaseDependencyCommandTest::testExceptionWhenItCouldNotFoundThePackage.
#[test]
#[serial]
-#[ignore]
fn test_exception_when_it_could_not_found_the_package() {
// caseProvider
let cases: Vec<(&str, Vec<(&str, PhpMixed)>)> = vec![
@@ -164,7 +163,6 @@ fn test_exception_when_it_could_not_found_the_package() {
/// ref: BaseDependencyCommandTest::testExceptionWhenPackageWasNotFoundInProject.
#[test]
#[serial]
-#[ignore]
fn test_exception_when_package_was_not_found_in_project() {
// caseProvider
let cases: Vec<(&str, Vec<(&str, PhpMixed)>)> = vec![
@@ -287,7 +285,6 @@ fn test_warning_when_dependencies_are_not_installed() {
/// ref: BaseDependencyCommandTest::testWhyCommandOutputs (caseWhyProvider rolled in).
#[test]
#[serial]
-#[ignore]
fn test_why_command_outputs() {
// caseWhyProvider: (package, --tree, --recursive, expected_output, expected_status_code)
let cases: Vec<(&str, bool, bool, &str, i32)> = vec![
diff --git a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs
index f01f9062..18eff41e 100644
--- a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs
+++ b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs
@@ -100,7 +100,6 @@ fn test_exception_thrown_if_no_lockfile_found() {
#[test]
#[serial]
-#[ignore]
fn test_failed_platform_requirement() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
diff --git a/crates/shirabe/tests/command/install_command_test.rs b/crates/shirabe/tests/command/install_command_test.rs
index 20636c9b..55ea9964 100644
--- a/crates/shirabe/tests/command/install_command_test.rs
+++ b/crates/shirabe/tests/command/install_command_test.rs
@@ -62,7 +62,6 @@ Generating autoload files"#,
#[test]
#[serial]
-#[ignore]
fn test_install_command_errors() {
for (label, composer_json, command, expected) in error_cases() {
let _tear_down = init_temp_composer(Some(&composer_json), None, None, true);
@@ -88,7 +87,6 @@ fn test_install_command_errors() {
#[test]
#[serial]
-#[ignore]
fn test_install_from_empty_vendor() {
let composer_json = serde_json::json!({
"require": { "root/req": "1.*" },
@@ -129,7 +127,6 @@ Generating autoload files",
#[test]
#[serial]
-#[ignore]
fn test_install_from_empty_vendor_no_dev() {
let composer_json = serde_json::json!({
"require": { "root/req": "1.*" },
@@ -170,7 +167,6 @@ Generating autoload files",
#[test]
#[serial]
-#[ignore]
fn test_install_new_packages_with_existing_partial_vendor() {
let composer_json = serde_json::json!({
"require": {
diff --git a/crates/shirabe/tests/command/remove_command_test.rs b/crates/shirabe/tests/command/remove_command_test.rs
index 75ef5075..252496ea 100644
--- a/crates/shirabe/tests/command/remove_command_test.rs
+++ b/crates/shirabe/tests/command/remove_command_test.rs
@@ -86,7 +86,6 @@ fn test_exception_when_running_unused_without_lock_file() {
#[test]
#[serial]
-#[ignore]
fn test_warning_when_removing_non_existent_package() {
let tear_down = init_temp_composer(None, None, None, true);
create_installed_json(&[], &[], true);
@@ -259,7 +258,6 @@ fn test_message_output_when_no_unused_packages_to_remove() {
#[test]
#[serial]
-#[ignore]
fn test_remove_unused_package() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -325,7 +323,6 @@ fn test_remove_unused_package() {
#[test]
#[serial]
-#[ignore]
fn test_remove_package_by_name() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -410,7 +407,6 @@ fn test_remove_package_by_name() {
#[test]
#[serial]
-#[ignore]
fn test_remove_package_by_name_with_dry_run() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -497,7 +493,6 @@ fn test_remove_package_by_name_with_dry_run() {
#[test]
#[serial]
-#[ignore]
fn test_remove_allowed_plugin_package_with_no_other_allowed_plugins() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -555,7 +550,6 @@ fn test_remove_allowed_plugin_package_with_no_other_allowed_plugins() {
#[test]
#[serial]
-#[ignore]
fn test_remove_allowed_plugin_package_with_other_allowed_plugins() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -607,7 +601,6 @@ fn test_remove_allowed_plugin_package_with_other_allowed_plugins() {
#[test]
#[serial]
-#[ignore]
fn test_remove_packages_by_vendor() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -691,7 +684,6 @@ fn test_remove_packages_by_vendor() {
#[test]
#[serial]
-#[ignore]
fn test_remove_packages_by_vendor_with_dry_run() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -969,7 +961,6 @@ fn run_update_inherited_dependencies_flag_case(
#[test]
#[serial]
-#[ignore]
fn test_update_inherited_dependencies_flag_is_passed_to_post_remove_installer() {
// 'update with all dependencies'
run_update_inherited_dependencies_flag_case(
diff --git a/crates/shirabe/tests/command/show_command_test.rs b/crates/shirabe/tests/command/show_command_test.rs
index 0d1acc5b..d00852dd 100644
--- a/crates/shirabe/tests/command/show_command_test.rs
+++ b/crates/shirabe/tests/command/show_command_test.rs
@@ -167,7 +167,6 @@ fn test_show_with_direct_shows_only_root_deps() {
#[test]
#[serial]
-#[ignore]
fn test_show_outdated_deps() {
run_show_case(
input(vec![("command", PhpMixed::from("outdated"))]),
@@ -211,7 +210,6 @@ outdated/major 1.0.0 ~ 2.0.0 from today",
#[test]
#[serial]
-#[ignore]
fn test_show_outdated_deps_with_direct_only_show_direct_deps_with_updated() {
run_show_case(
input(vec![
@@ -231,7 +229,6 @@ outdated/major 1.0.0 ~ 2.0.0",
#[test]
#[serial]
-#[ignore]
fn test_show_outdated_deps_with_direct_show_msg_if_all_up_to_date() {
run_show_case(
input(vec![
@@ -245,7 +242,6 @@ fn test_show_outdated_deps_with_direct_show_msg_if_all_up_to_date() {
#[test]
#[serial]
-#[ignore]
fn test_show_outdated_deps_with_major_only() {
run_show_case(
input(vec![
@@ -267,7 +263,6 @@ outdated/major 1.0.0 ~ 2.0.0",
#[test]
#[serial]
-#[ignore]
fn test_show_outdated_deps_with_minor_only() {
run_show_case(
input(vec![
@@ -290,7 +285,6 @@ outdated/patch 1.0.0 <highlight>! 1.0.1</highlight>",
#[test]
#[serial]
-#[ignore]
fn test_show_outdated_deps_with_patch_only() {
run_show_case(
input(vec![
@@ -648,7 +642,6 @@ fn test_show_platform_works_without_composer_json() {
#[test]
#[serial]
-#[ignore]
fn test_outdated_with_zero_major() {
let _tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -1271,7 +1264,6 @@ fn test_not_existing_package_with_locked_option() {
#[test]
#[serial]
-#[ignore]
fn test_not_existing_platform_with_platform_option() {
run_not_existing_package_case(
"ext-nonexisting",
diff --git a/crates/shirabe/tests/command/suggests_command_test.rs b/crates/shirabe/tests/command/suggests_command_test.rs
index da9e92d9..e6732dc8 100644
--- a/crates/shirabe/tests/command/suggests_command_test.rs
+++ b/crates/shirabe/tests/command/suggests_command_test.rs
@@ -49,7 +49,6 @@ fn link(source: &str, target: &str, description: &str) -> Link {
#[test]
#[serial]
-#[ignore]
fn test_installed_packages_with_no_suggestions() {
let tear_down = init_temp_composer(
Some(&serde_json::json!({
@@ -216,7 +215,6 @@ fn run_suggest_case(has_lock_file: bool, command: &[(&str, PhpMixed)], expected:
#[test]
#[serial]
-#[ignore]
fn test_suggest() {
let t = PhpMixed::from(true);
let by_package = ("--by-package", t.clone());
diff --git a/crates/shirabe/tests/command/update_command_test.rs b/crates/shirabe/tests/command/update_command_test.rs
index 2fc20269..1b36cadc 100644
--- a/crates/shirabe/tests/command/update_command_test.rs
+++ b/crates/shirabe/tests/command/update_command_test.rs
@@ -519,7 +519,6 @@ fn test_interactive_tmp() {
#[test]
#[serial]
-#[ignore]
fn test_no_security_blocking_allows_insecure_packages() {
let composer_json = serde_json::json!({
"repositories": { "packages": {