aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/command
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-19 15:20:26 +0900
committernsfisis <nsfisis@gmail.com>2026-07-19 17:53:42 +0900
commit82cd8e8051ef791b9224916a5e2060ad38c1f82b (patch)
tree32c1428f354c2f43df1819c5c5ee74dfdd6c403f /crates/shirabe/tests/command
parenta3334ee267d3e905646bdb49c2edc8774ac8d966 (diff)
downloadphp-shirabe-82cd8e8051ef791b9224916a5e2060ad38c1f82b.tar.gz
php-shirabe-82cd8e8051ef791b9224916a5e2060ad38c1f82b.tar.zst
php-shirabe-82cd8e8051ef791b9224916a5e2060ad38c1f82b.zip
fix(update-command): un-ignore test_update by fixing 3 real bugs
test_update was skipped for a stale reason; running it uncovered three distinct bugs it was actually catching: - ApplicationTester::run never restored SHELL_VERBOSITY after Application::configureIO mutates it, so one dataset's -vv verbosity leaked into later runs sharing the process (Symfony's tester restores it in a finally block; the port dropped that). - Installer::do_install built its RepositorySet with a hardcoded empty temporary_constraints map instead of self.temporary_constraints, so --with never actually constrained the resolver. - BumpCommand was missing a <warning> tag pair around one of its output lines.
Diffstat (limited to 'crates/shirabe/tests/command')
-rw-r--r--crates/shirabe/tests/command/update_command_test.rs3
1 files changed, 0 insertions, 3 deletions
diff --git a/crates/shirabe/tests/command/update_command_test.rs b/crates/shirabe/tests/command/update_command_test.rs
index 866755bf..ed17d80e 100644
--- a/crates/shirabe/tests/command/update_command_test.rs
+++ b/crates/shirabe/tests/command/update_command_test.rs
@@ -235,7 +235,6 @@ Your requirements could not be resolved to an installable set of packages.
#[test]
#[serial]
-#[ignore = "regex porting: a Preg pattern starting with \"^array \" fails to compile in shirabe-php-shim preg.rs (\"unterminated regex pattern\"); unrelated to InputDefinition"]
fn test_update() {
for (label, composer_json, command, expected, create_lock) in provide_updates() {
let _tear_down = init_temp_composer(Some(&composer_json), None, None, true);
@@ -260,7 +259,6 @@ fn test_update() {
#[test]
#[serial]
-#[ignore = "resolver does not emit the temporary-update-constraint conflict; it performs the upgrade instead of reporting \"conflicts with your temporary update constraint\""]
fn test_update_with_patch_only() {
let composer_json = serde_json::json!({
"repositories": { "packages": { "type": "package", "package": [
@@ -604,7 +602,6 @@ fn test_no_security_blocking_allows_insecure_packages() {
#[test]
#[serial]
-#[ignore = "solver error \"Fixed package __root__ 1.0.0+no-version-set was not added to solver pool.\" on the no-lockfile bump path (resolver pool construction)"]
fn test_bump_after_update_without_lockfile() {
let composer_json = serde_json::json!({
"repositories": { "packages": { "type": "package", "package": [