diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-26 02:26:08 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-26 02:26:08 +0900 |
| commit | 8c4dc6cd48457f154eb067f296d79ef911573c91 (patch) | |
| tree | 10acc2f4f64813f9b206d474306e5680234ec73d /crates/shirabe/tests/command | |
| parent | 6c89c720d9e4728c288e3c66ffb7dcb4cba5121c (diff) | |
| download | php-shirabe-8c4dc6cd48457f154eb067f296d79ef911573c91.tar.gz php-shirabe-8c4dc6cd48457f154eb067f296d79ef911573c91.tar.zst php-shirabe-8c4dc6cd48457f154eb067f296d79ef911573c91.zip | |
fix(check-platform-reqs-command): add PlatformRepository to existing composite
execute nested the already-built InstalledRepository inside a second
InstalledRepository, tripping the assertion that an InstalledRepository may not
contain another. PHP adds a PlatformRepository to the existing composite via
addRepository; do the same.
Un-ignores CheckPlatformReqsCommandTest::test_failed_platform_requirement.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/command')
| -rw-r--r-- | crates/shirabe/tests/command/check_platform_reqs_command_test.rs | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs index 1e19259..a9196b7 100644 --- a/crates/shirabe/tests/command/check_platform_reqs_command_test.rs +++ b/crates/shirabe/tests/command/check_platform_reqs_command_test.rs @@ -48,11 +48,7 @@ fn run_platform_reqs_are_satisfied_case( #[test] #[serial] -#[ignore = "src porting bug: check_platform_reqs_command.rs:288-294 wraps the existing \ - InstalledRepository inside a SECOND InstalledRepository (instead of PHP line 89 \ - `$installedRepo->addRepository(new PlatformRepository(...))`), tripping the \ - add_repository assertion at installed_repository.rs:367 (\"An InstalledRepository can \ - not contain a repository of type installed repo ...\"). Cannot fix from test files."] +#[ignore = "reaches a RefCell re-entrancy panic at crates/shirabe/src/downloader/file_downloader.rs:136 (\"RefCell already borrowed\") on the platform-package resolution path; src borrow bug, not fixable from the test"] fn test_platform_reqs_are_satisfied() { // 'Disables checking of require-dev packages requirements.' run_platform_reqs_are_satisfied_case( @@ -105,11 +101,6 @@ fn test_exception_thrown_if_no_lockfile_found() { #[test] #[serial] -#[ignore = "src porting bug: check_platform_reqs_command.rs:288-294 wraps the existing \ - InstalledRepository inside a SECOND InstalledRepository (instead of PHP line 89 \ - `$installedRepo->addRepository(new PlatformRepository(...))`), tripping the \ - add_repository assertion at installed_repository.rs:367 (\"An InstalledRepository can \ - not contain a repository of type installed repo ...\"). Cannot fix from test files."] fn test_failed_platform_requirement() { let tear_down = init_temp_composer( Some(&serde_json::json!({ |