fix(io): propagate ask/select errors instead of panicking

IOInterface::ask/select now return anyhow::Result<PhpMixed>, and
ConsoleIO::ask_question forwards QuestionHelper errors (validator
failures, MissingInputException) instead of collapsing them with
.expect(). In PHP these exceptions propagate from QuestionHelper
through ConsoleIO to the caller, so callers such as UpdateCommand's
interactive package selection must be able to observe them; the
MissingInputException is wrapped with its concrete type preserved so
Application's ExceptionInterface downcast keeps working. All call
sites now propagate with `?` (Perforce::query_p4_user becomes
Result-returning: PHP declares it void but exceptions still escape),
and the previously ignored
test_interactive_mode_throws_if_no_package_entered passes.

ask_confirmation/ask_and_hide_answer still collapse errors; extending
propagation to them is left as TODO(phase-c) pending a decision.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

1 files changed, 9 insertions, 6 deletions

diff --git a/crates/shirabe/tests/common/io_mock.rs b/crates/shirabe/tests/common/io_mock.rs
index a658c5bc..ad8d72cd 100644
--- a/crates/shirabe/tests/common/io_mock.rs
+++ b/crates/shirabe/tests/common/io_mock.rs
@@ -224,7 +224,7 @@ impl IOInterfaceImmutable for IOMock {
             .overwrite_error4(message, newline, size, verbosity)
     }
 
-    fn ask(&self, question: String, default: PhpMixed) -> PhpMixed {
+    fn ask(&self, question: String, default: PhpMixed) -> anyhow::Result<PhpMixed> {
         self.inner
             .ask(format!("{}{}", trim_eol(&question), PHP_EOL), default)
     }
@@ -249,10 +249,13 @@ impl IOInterfaceImmutable for IOMock {
     fn ask_and_hide_answer(&self, question: String) -> Option<String> {
         // Do not hide the answer in tests because that blocks on Windows with
         // hiddeninput.exe, so PHP delegates to `ask` rather than the hidden variant.
-        let result = self.inner.ask(
-            format!("{}{}", trim_eol(&question), PHP_EOL),
-            PhpMixed::Null,
-        );
+        let result = self
+            .inner
+            .ask(
+                format!("{}{}", trim_eol(&question), PHP_EOL),
+                PhpMixed::Null,
+            )
+            .expect("QuestionHelper::ask raised an error");
         result.as_string().map(|s| s.to_string())
     }
     fn select(
@@ -263,7 +266,7 @@ impl IOInterfaceImmutable for IOMock {
         attempts: PhpMixed,
         error_message: String,
         multiselect: bool,
-    ) -> PhpMixed {
+    ) -> anyhow::Result<PhpMixed> {
         self.inner.select(
             format!("{}{}", trim_eol(&question), PHP_EOL),
             choices,