diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
| commit | 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch) | |
| tree | b19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/config_test.rs | |
| parent | 80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff) | |
| download | php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip | |
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each:
25 now pass and had the attribute removed; the remaining 49 got a
concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type
mismatches, config bool-coercion bugs, missing skipped_load wiring
in PoolBuilder, etc.) so future work can find and fix them by grep.
No production code or test logic/assertions were changed.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/config_test.rs')
| -rw-r--r-- | crates/shirabe/tests/config_test.rs | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/crates/shirabe/tests/config_test.rs b/crates/shirabe/tests/config_test.rs index e8feafd7..2d80b625 100644 --- a/crates/shirabe/tests/config_test.rs +++ b/crates/shirabe/tests/config_test.rs @@ -413,7 +413,6 @@ fn test_override_github_protocols() { ); } -#[ignore] #[test] fn test_git_disabled_by_default_in_github_protocols() { let mut config = Config::new(false, None); @@ -445,7 +444,7 @@ fn test_git_disabled_by_default_in_github_protocols() { ); } -#[ignore] +#[ignore = "shirabe_php_shim::filter::filter_var_url (reqwest::Url::parse) accepts \"git:Department/Repo.git\" as a valid cannot-be-a-base URL, while PHP's FILTER_VALIDATE_URL rejects it; the malformed-URL early-return in prohibit_url_by_config is skipped and the git scheme then hits the secure-http rejection"] #[test] fn test_allowed_urls_pass() { let urls = vec![ @@ -521,7 +520,7 @@ fn test_prohibited_urls_warning_verify_peer() { .unwrap(); } -#[ignore] +#[ignore = "Config::get's disable-tls/secure-http/use-github-api/lock branch casts via v.as_bool().unwrap_or(false) instead of PhpMixed::to_bool() (PHP's (bool) cast), so a truthy String(\"true\") is read back as false"] #[test] fn test_disable_tls_can_be_overridden() { let mut config = Config::new(true, None); @@ -548,7 +547,7 @@ fn test_process_timeout() { assert_eq!(PhpMixed::Int(0), result); } -#[ignore] +#[ignore = "Config::get's cache-read-only/htaccess-protect branch casts via val.as_bool().unwrap_or_else(|| !val.is_null()) instead of PhpMixed::to_bool() (PHP's (bool) cast), so String(\"0\") from COMPOSER_HTACCESS_PROTECT is read back as true instead of false"] #[test] #[serial] fn test_htaccess_protect() { |
