diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
| commit | 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch) | |
| tree | b19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/dependency_resolver | |
| parent | 80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff) | |
| download | php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip | |
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each:
25 now pass and had the attribute removed; the remaining 49 got a
concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type
mismatches, config bool-coercion bugs, missing skipped_load wiring
in PoolBuilder, etc.) so future work can find and fix them by grep.
No production code or test logic/assertions were changed.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/dependency_resolver')
| -rw-r--r-- | crates/shirabe/tests/dependency_resolver/default_policy_test.rs | 1 | ||||
| -rw-r--r-- | crates/shirabe/tests/dependency_resolver/pool_builder_test.rs | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/crates/shirabe/tests/dependency_resolver/default_policy_test.rs b/crates/shirabe/tests/dependency_resolver/default_policy_test.rs index 3757715f..2717954c 100644 --- a/crates/shirabe/tests/dependency_resolver/default_policy_test.rs +++ b/crates/shirabe/tests/dependency_resolver/default_policy_test.rs @@ -172,7 +172,6 @@ fn test_select_newest_picks_latest_stable_with_prefer_stable() { assert_eq!(expected, selected); } -#[ignore] #[test] #[serial] fn test_select_lowest_with_prefer_dev_over_prerelease() { diff --git a/crates/shirabe/tests/dependency_resolver/pool_builder_test.rs b/crates/shirabe/tests/dependency_resolver/pool_builder_test.rs index 659f5e48..ce5310b2 100644 --- a/crates/shirabe/tests/dependency_resolver/pool_builder_test.rs +++ b/crates/shirabe/tests/dependency_resolver/pool_builder_test.rs @@ -621,7 +621,7 @@ fn run_test_pool_builder( std::env::set_current_dir(&old_cwd).unwrap(); } -#[ignore] +#[ignore = "PoolBuilder::build_pool never populates skipped_load (PHP populates it at buildPool's lockedPackage loop, incl. its replace targets), so load_package's skipped_load-driven transitive unlock branch never fires; fails partial-update-unfixing-with-replacers-providers.test"] #[test] fn test_pool_builder() { let fixtures_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")) |