aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/installer
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-25 16:16:33 +0900
committernsfisis <nsfisis@gmail.com>2026-07-25 16:17:10 +0900
commit432472808051cb4f1bb9517b858dbc810aaa5a63 (patch)
tree4c58b97942853ea2c3f58368203fa93187746cf8 /crates/shirabe/tests/installer
parentd4608662f28b9a5135986b1702afe3199957eabe (diff)
downloadphp-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.gz
php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.zst
php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.zip
refactor: replace redundant clones with moves
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/installer')
-rw-r--r--crates/shirabe/tests/installer/installation_manager_test.rs8
-rw-r--r--crates/shirabe/tests/installer/library_installer_test.rs4
2 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe/tests/installer/installation_manager_test.rs b/crates/shirabe/tests/installer/installation_manager_test.rs
index 867e759a..3f18e925 100644
--- a/crates/shirabe/tests/installer/installation_manager_test.rs
+++ b/crates/shirabe/tests/installer/installation_manager_test.rs
@@ -358,7 +358,7 @@ fn test_install() {
shirabe::installer::InstallationManager::new(set_up.loop_.clone(), set_up.io.clone(), None);
manager.add_installer(Box::new(installer));
- let operation = InstallOperation::new(package.clone());
+ let operation = InstallOperation::new(package);
let mut repository = InstalledArrayRepository::new().unwrap();
run(manager.install(
@@ -393,7 +393,7 @@ fn test_update_with_equal_types() {
shirabe::installer::InstallationManager::new(set_up.loop_.clone(), set_up.io.clone(), None);
manager.add_installer(Box::new(installer));
- let operation = UpdateOperation::new(initial.clone(), target.clone());
+ let operation = UpdateOperation::new(initial, target);
let mut repository = InstalledArrayRepository::new().unwrap();
run(manager.update(
@@ -438,7 +438,7 @@ fn test_update_with_not_equal_types() {
manager.add_installer(Box::new(lib_installer));
manager.add_installer(Box::new(bundle_installer));
- let operation = UpdateOperation::new(initial.clone(), target.clone());
+ let operation = UpdateOperation::new(initial, target);
let mut repository = InstalledArrayRepository::new().unwrap();
run(manager.update(
@@ -469,7 +469,7 @@ fn test_uninstall() {
shirabe::installer::InstallationManager::new(set_up.loop_.clone(), set_up.io.clone(), None);
manager.add_installer(Box::new(installer));
- let operation = UninstallOperation::new(package.clone());
+ let operation = UninstallOperation::new(package);
let mut repository = InstalledArrayRepository::new().unwrap();
run(manager.uninstall(
diff --git a/crates/shirabe/tests/installer/library_installer_test.rs b/crates/shirabe/tests/installer/library_installer_test.rs
index f9dceb56..8a063941 100644
--- a/crates/shirabe/tests/installer/library_installer_test.rs
+++ b/crates/shirabe/tests/installer/library_installer_test.rs
@@ -446,7 +446,7 @@ fn test_ensure_binaries_installed() {
binary_installer.expect_remove_binaries().times(0);
// PHP asserts installBinaries is called once with ($package, getInstallPath, false).
let expected_package = package.clone();
- let expected_install_path = expected_path.clone();
+ let expected_install_path = expected_path;
binary_installer
.expect_install_binaries()
.times(1)
@@ -458,7 +458,7 @@ fn test_ensure_binaries_installed() {
.returning(|_, _, _| ());
library.__set_binary_installer(std::rc::Rc::new(std::cell::RefCell::new(binary_installer)));
- library.ensure_binaries_presence(package.clone());
+ library.ensure_binaries_presence(package);
tear_down(&mut setup);
}