diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-24 20:23:09 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-24 20:23:09 +0900 |
| commit | 7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd (patch) | |
| tree | e86b6901fff39375d8ae5c181b2b93f29f99888d /crates/shirabe/tests/installer_test.rs | |
| parent | 4ddeca53cca2c6764283c3a32c74f8e689cc5b9c (diff) | |
| download | php-shirabe-7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd.tar.gz php-shirabe-7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd.tar.zst php-shirabe-7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd.zip | |
fix(composer-repository): initialize wrapper before delegating loadPackages
For a simple, non-lazy composer repository (no providers-url/
metadata-url/providers-lazy-url), load_packages() delegates to
self.inner.load_packages() (PHP: parent::loadPackages()). PHP's
ArrayRepository::loadPackages() calls $this->getPackages(), which
virtual-dispatches through ComposerRepository::getPackages() down to
ComposerRepository::initialize() (the real HTTP/file fetch).
Composition doesn't get that dispatch for free: self.inner is a bare
ArrayRepository, so self.inner.load_packages() ends up calling
ArrayRepository::initialize() — a no-op stub that just sets an empty
package list — instead of ComposerRepository::initialize(). The
repository's packages.json fetched and parsed successfully, but the
result was silently discarded, so the repo always looked empty.
get_packages() already carries the identical guard with the same
diagnosis in its own comment; load_packages() was just missing it.
Documented the same latent gap in find_package/find_packages/count/
has_package, which call into ArrayRepository the same unguarded way
but aren't known to be exercised by any test yet.
Diffstat (limited to 'crates/shirabe/tests/installer_test.rs')
| -rw-r--r-- | crates/shirabe/tests/installer_test.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/tests/installer_test.rs b/crates/shirabe/tests/installer_test.rs index e8fa7bc6..13e4fc28 100644 --- a/crates/shirabe/tests/installer_test.rs +++ b/crates/shirabe/tests/installer_test.rs @@ -1392,7 +1392,7 @@ pool_optimizer_test! { pool_optimizer_github_issues_9290 => "github-issues-9290.test"; pool_optimizer_hint_main_rename => "hint-main-rename.test"; pool_optimizer_install_aliased_alias => "install-aliased-alias.test"; - pool_optimizer_install_branch_alias_composer_repo => "install-branch-alias-composer-repo.test", ignore = "TODO(phase-d): known-failing fixture under COMPOSER_POOL_OPTIMIZER=1"; + pool_optimizer_install_branch_alias_composer_repo => "install-branch-alias-composer-repo.test"; pool_optimizer_install_dev_using_dist => "install-dev-using-dist.test"; pool_optimizer_install_dev => "install-dev.test"; pool_optimizer_install_forces_reinstall_if_abandon_changes => "install-forces-reinstall-if-abandon-changes.test"; @@ -1582,7 +1582,7 @@ raw_pool_test! { raw_pool_github_issues_9290 => "github-issues-9290.test"; raw_pool_hint_main_rename => "hint-main-rename.test"; raw_pool_install_aliased_alias => "install-aliased-alias.test"; - raw_pool_install_branch_alias_composer_repo => "install-branch-alias-composer-repo.test", ignore = "TODO(phase-d): known-failing fixture under COMPOSER_POOL_OPTIMIZER=0"; + raw_pool_install_branch_alias_composer_repo => "install-branch-alias-composer-repo.test"; raw_pool_install_dev_using_dist => "install-dev-using-dist.test"; raw_pool_install_dev => "install-dev.test"; raw_pool_install_forces_reinstall_if_abandon_changes => "install-forces-reinstall-if-abandon-changes.test"; |
