diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-27 08:58:01 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-27 09:09:44 +0900 |
| commit | 2e4a3cf59df1bc85b0f626f598a5d45bcae8d77a (patch) | |
| tree | f125fb944ad57b1819447eb61b5adfa687f25e34 /crates/shirabe/tests/json/json_file_test.rs | |
| parent | 901878ee3f2bee6605b02d321cc4c92bc32fd5b0 (diff) | |
| download | php-shirabe-2e4a3cf59df1bc85b0f626f598a5d45bcae8d77a.tar.gz php-shirabe-2e4a3cf59df1bc85b0f626f598a5d45bcae8d77a.tar.zst php-shirabe-2e4a3cf59df1bc85b0f626f598a5d45bcae8d77a.zip | |
fix(json): include property name in required-property errors
The jsonschema crate reports a missing required property against its
parent object, leaving the instance path empty at the root. This skipped
the "PROPERTY : MESSAGE" formatting that Composer produces. Append the
missing property name to the path so the output shape matches.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/json/json_file_test.rs')
| -rw-r--r-- | crates/shirabe/tests/json/json_file_test.rs | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/crates/shirabe/tests/json/json_file_test.rs b/crates/shirabe/tests/json/json_file_test.rs index cd4445c..3b56d35 100644 --- a/crates/shirabe/tests/json/json_file_test.rs +++ b/crates/shirabe/tests/json/json_file_test.rs @@ -304,9 +304,9 @@ fn test_schema_validation_lax_additional_properties() { #[test] fn test_schema_validation_lax_required() { // WORDING NOTE: upstream asserts justinrainbow's property-prefixed strings such as - // "name : The property name is required". The jsonschema crate reports the same required - // violations as "\"name\" is a required property" (no property prefix; the property name is - // embedded in the message). + // "name : The property name is required". The jsonschema crate phrases the message + // differently ("name : \"name\" is a required property"), but the property prefix is reconstructed, + // so the "PROPERTY : MESSAGE" shape matches: "name : \"name\" is a required property". let file_tmp = create_temp_file(); let file = file_tmp.path().to_str().unwrap().to_string(); let json = JsonFile::new(file.clone(), None, None).unwrap(); @@ -320,8 +320,8 @@ fn test_schema_validation_lax_required() { let e = err.downcast_ref::<JsonValidationException>().unwrap(); assert_eq!(expected_message, e.get_message()); let errors = e.get_errors(); - assert!(errors.contains(&"\"name\" is a required property".to_string())); - assert!(errors.contains(&"\"description\" is a required property".to_string())); + assert!(errors.contains(&"name : \"name\" is a required property".to_string())); + assert!(errors.contains(&"description : \"description\" is a required property".to_string())); json.validate_schema(JsonFile::LAX_SCHEMA, None).unwrap(); std::fs::write(&file, b"{ \"name\": \"vendor/package\" }").unwrap(); @@ -331,7 +331,7 @@ fn test_schema_validation_lax_required() { let e = err.downcast_ref::<JsonValidationException>().unwrap(); assert_eq!(expected_message, e.get_message()); assert_eq!( - &vec!["\"description\" is a required property".to_string()], + &vec!["description : \"description\" is a required property".to_string()], e.get_errors() ); json.validate_schema(JsonFile::LAX_SCHEMA, None).unwrap(); @@ -343,7 +343,7 @@ fn test_schema_validation_lax_required() { let e = err.downcast_ref::<JsonValidationException>().unwrap(); assert_eq!(expected_message, e.get_message()); assert_eq!( - &vec!["\"name\" is a required property".to_string()], + &vec!["name : \"name\" is a required property".to_string()], e.get_errors() ); json.validate_schema(JsonFile::LAX_SCHEMA, None).unwrap(); @@ -355,8 +355,8 @@ fn test_schema_validation_lax_required() { let e = err.downcast_ref::<JsonValidationException>().unwrap(); assert_eq!(expected_message, e.get_message()); let errors = e.get_errors(); - assert!(errors.contains(&"\"name\" is a required property".to_string())); - assert!(errors.contains(&"\"description\" is a required property".to_string())); + assert!(errors.contains(&"name : \"name\" is a required property".to_string())); + assert!(errors.contains(&"description : \"description\" is a required property".to_string())); json.validate_schema(JsonFile::LAX_SCHEMA, None).unwrap(); std::fs::write(&file, b"{ \"type\": \"project\" }").unwrap(); @@ -366,8 +366,8 @@ fn test_schema_validation_lax_required() { let e = err.downcast_ref::<JsonValidationException>().unwrap(); assert_eq!(expected_message, e.get_message()); let errors = e.get_errors(); - assert!(errors.contains(&"\"name\" is a required property".to_string())); - assert!(errors.contains(&"\"description\" is a required property".to_string())); + assert!(errors.contains(&"name : \"name\" is a required property".to_string())); + assert!(errors.contains(&"description : \"description\" is a required property".to_string())); json.validate_schema(JsonFile::LAX_SCHEMA, None).unwrap(); std::fs::write( |
