aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/json/json_file_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
committernsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
commit37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch)
treeb19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/json/json_file_test.rs
parent80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff)
downloadphp-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/json/json_file_test.rs')
-rw-r--r--crates/shirabe/tests/json/json_file_test.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/shirabe/tests/json/json_file_test.rs b/crates/shirabe/tests/json/json_file_test.rs
index 217592f8..bc0fe223 100644
--- a/crates/shirabe/tests/json/json_file_test.rs
+++ b/crates/shirabe/tests/json/json_file_test.rs
@@ -204,7 +204,7 @@ fn test_double_escaped_unicode() {
}
#[test]
-#[ignore]
+#[ignore = "JsonFile::write never forwards self.indent (set by read()'s detect_indenting) into the encode options, unlike PHP's write() which passes $this->indent to encode()"]
fn test_preserve_indentation_after_read() {
let src = fixture_path("tabs.json");
let dst = fixture_path("tabs2.json");