diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 18:19:24 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 18:19:24 +0900 |
| commit | dc0087845355222d1cbf2820289444db3eebc87e (patch) | |
| tree | d61e5d31099ec9f05284a16e4f0044c759698d5c /crates/shirabe/tests/json | |
| parent | dbb91e0c4b61b7c1106a9d3aefcab6f2598b93d4 (diff) | |
| download | php-shirabe-dc0087845355222d1cbf2820289444db3eebc87e.tar.gz php-shirabe-dc0087845355222d1cbf2820289444db3eebc87e.tar.zst php-shirabe-dc0087845355222d1cbf2820289444db3eebc87e.zip | |
fix(json-file): forward detected indent into write's encode options
JsonFile::write_with_options() used the caller-supplied JsonEncodeOptions
verbatim, ignoring self.indent (set by read()'s detect_indenting), unlike
PHP's write() which always passes $this->indent to encode() regardless of
the $options argument. Un-ignore test_preserve_indentation_after_read.
Diffstat (limited to 'crates/shirabe/tests/json')
| -rw-r--r-- | crates/shirabe/tests/json/json_file_test.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/crates/shirabe/tests/json/json_file_test.rs b/crates/shirabe/tests/json/json_file_test.rs index bc0fe223..14cb1e68 100644 --- a/crates/shirabe/tests/json/json_file_test.rs +++ b/crates/shirabe/tests/json/json_file_test.rs @@ -204,7 +204,6 @@ fn test_double_escaped_unicode() { } #[test] -#[ignore = "JsonFile::write never forwards self.indent (set by read()'s detect_indenting) into the encode options, unlike PHP's write() which passes $this->indent to encode()"] fn test_preserve_indentation_after_read() { let src = fixture_path("tabs.json"); let dst = fixture_path("tabs2.json"); |