aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/package/complete_package_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-24 20:23:09 +0900
committernsfisis <nsfisis@gmail.com>2026-07-24 20:23:09 +0900
commit7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd (patch)
treee86b6901fff39375d8ae5c181b2b93f29f99888d /crates/shirabe/tests/package/complete_package_test.rs
parent4ddeca53cca2c6764283c3a32c74f8e689cc5b9c (diff)
downloadphp-shirabe-7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd.tar.gz
php-shirabe-7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd.tar.zst
php-shirabe-7d29b5116d51a2f4ae5f90b1ef33a4b1454edebd.zip
fix(composer-repository): initialize wrapper before delegating loadPackages
For a simple, non-lazy composer repository (no providers-url/ metadata-url/providers-lazy-url), load_packages() delegates to self.inner.load_packages() (PHP: parent::loadPackages()). PHP's ArrayRepository::loadPackages() calls $this->getPackages(), which virtual-dispatches through ComposerRepository::getPackages() down to ComposerRepository::initialize() (the real HTTP/file fetch). Composition doesn't get that dispatch for free: self.inner is a bare ArrayRepository, so self.inner.load_packages() ends up calling ArrayRepository::initialize() — a no-op stub that just sets an empty package list — instead of ComposerRepository::initialize(). The repository's packages.json fetched and parsed successfully, but the result was silently discarded, so the repo always looked empty. get_packages() already carries the identical guard with the same diagnosis in its own comment; load_packages() was just missing it. Documented the same latent gap in find_package/find_packages/count/ has_package, which call into ArrayRepository the same unguarded way but aren't known to be exercised by any test yet.
Diffstat (limited to 'crates/shirabe/tests/package/complete_package_test.rs')
0 files changed, 0 insertions, 0 deletions