fix(process-executor): un-ignore 11 tests by implementing execute_async mock support

ProcessExecutor::execute_async's mock branch was an unimplemented
todo!(), blocking every test whose code path calls it (feature-branch
git diffing, system-unzip/7z fallback extraction). Implement it by:

- Adding Process::__mock (mirroring the existing ZipArchive::__mock
  pattern) so execute_async can resolve with a fabricated, already-
  terminated Process instead of spawning a real subprocess.
- Extracting the sync mock's expectation-matching logic into a shared
  ProcessExecutor::mock_match, wrapping the mock state in a RefCell so
  it works from execute_async's &self/&mut self receivers.
- Setting error_output/capture_output from the mock branch, matching
  PHP's ProcessExecutorMock::executeAsync sharing doExecute with the
  sync path; execute_async now takes &mut self for this (safe, since
  the borrow only needs to live through the synchronous setup, not
  across the .await).
- Turning a strict-mode expectation mismatch from a panic!() into a
  shirabe_php_shim::RuntimeException Err, mirroring PHPUnit's
  AssertionFailedError extending \RuntimeException: PHP call sites
  that catch (\RuntimeException $e) around a mocked git/hg/svn call
  (e.g. Git::get_mirror_default_branch, GitDriver::supports) treat a
  mismatch as an ordinary recoverable failure, and now so does the
  port. The RefMut is dropped before firing an expectation's optional
  callback so a re-entrant callback doesn't panic on double-borrow.

Also fixes two real bugs found while porting test_private_repository_
no_interaction: GitHub::authorize_oauth and GitLab::authorize_oauth
checked their domains config via PhpMixed::as_array(), which only
matches the Array (map) variant, but github-domains/gitlab-domains
default to PhpMixed::List, so the check always returned false and OAuth
token lookup was silently skipped. Use the in_array shim instead,
matching PHP's in_array() semantics. Also fix Git::run_command's
"capture credentials from git remote -v" call, which used the panic-
swallowing execute_args wrapper instead of a fallible execute(), so a
mock mismatch there couldn't reach get_mirror_default_branch's catch.

Un-ignores:
- zip_downloader_test::test_system_unzip_only_{good,failed}
- zip_downloader_test::test_non_windows_fallback_{good,failed}
- event_dispatcher_test::test_dispatcher_outputs_error_on_failed_command
- root_package_loader_test::test_feature_branch_pretty_version
- version_guesser_test::test_guess_version_reads_and_respects_non_feature_branches_configuration_for_arbitrary_naming{,_regex}
- version_guesser_test::test_remote_branches_are_selected
- github_driver_test::test_private_repository_no_interaction (also
  adds the missing #[serial], since it seeds the shared Git::VERSION
  static that vcs_repository_test::test_load_versions depends on for
  real)
- init_command_test::test_get_git_config, made deterministic by
  pointing HOME at a throwaway dir with its own .gitconfig instead of
  depending on the host's global git config

Deduplicates the GitVersionGuard/RestoreEnv test-drop-guard idioms into
tests/common/test_case.rs instead of reimplementing them per file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

1 files changed, 1 insertions, 11 deletions

diff --git a/crates/shirabe/tests/package/loader/root_package_loader_test.rs b/crates/shirabe/tests/package/loader/root_package_loader_test.rs
index 069cf5a7..248c4e6a 100644
--- a/crates/shirabe/tests/package/loader/root_package_loader_test.rs
+++ b/crates/shirabe/tests/package/loader/root_package_loader_test.rs
@@ -5,6 +5,7 @@
 // look-around regex the regex crate cannot compile.
 
 use crate::process_executor_mock::{cmd, cmd_full, get_process_executor_mock};
+use crate::test_case::GitVersionGuard;
 use indexmap::IndexMap;
 use serial_test::serial;
 use shirabe::config::Config;
@@ -72,16 +73,6 @@ fn require_map(entries: &[(&str, &str)]) -> PhpMixed {
     PhpMixed::Array(m)
 }
 
-// Resets the cached git `version` static on drop so a seeded value does not leak into other
-// tests in this binary (VersionGuesserTest seeds/resets the same static).
-struct GitVersionGuard;
-
-impl Drop for GitVersionGuard {
-    fn drop(&mut self) {
-        GitUtil::__reset_version();
-    }
-}
-
 // A test double for the concrete VersionGuesser, supplied through the VersionGuesserInterface seam.
 mockall::mock! {
     #[derive(Debug)]
@@ -271,7 +262,6 @@ fn test_pretty_version_for_root_package_in_version_branch() {
 }
 
 #[test]
-#[ignore = "feature-branch guessing calls ProcessExecutor::execute_async, whose mock path is todo!()"]
 #[serial]
 fn test_feature_branch_pretty_version() {
     // proc_open() is always available; the PHP markTestSkipped guard does not apply here.