aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/repository/filesystem_repository_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
committernsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
commit37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch)
treeb19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/repository/filesystem_repository_test.rs
parent80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff)
downloadphp-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/repository/filesystem_repository_test.rs')
-rw-r--r--crates/shirabe/tests/repository/filesystem_repository_test.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/shirabe/tests/repository/filesystem_repository_test.rs b/crates/shirabe/tests/repository/filesystem_repository_test.rs
index b0d18c68..f2cdb670 100644
--- a/crates/shirabe/tests/repository/filesystem_repository_test.rs
+++ b/crates/shirabe/tests/repository/filesystem_repository_test.rs
@@ -51,7 +51,7 @@ fn test_repository_read() {
assert_eq!(packages[0].get_type(), "vendor");
}
-#[ignore]
+#[ignore = "InvalidRepositoryException message building calls shirabe_php_shim::var::get_class_err(), which is still todo!()"]
#[test]
fn test_corrupted_repository_file() {
// PHP mocks read() to return the scalar string 'foo'; a real file containing the JSON string
@@ -327,7 +327,7 @@ fn test_repository_writes_installed_php() {
assert_eq!(expected, actual);
}
-#[ignore]
+#[ignore = "safely_load_installed_versions's pattern uses a PCRE (?(DEFINE)...) recursive grammar the regex crate cannot compile"]
#[test]
fn test_safely_load_installed_versions() {
let fixtures_dir = format!(