aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/repository/repository_factory_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
committernsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
commit5ab5f3b316798c1411ce8e6a7f5b091fda93589c (patch)
treec7669f94f5d9bd9adc07bc1aab3f14cfdec1ae5f /crates/shirabe/tests/repository/repository_factory_test.rs
parentb291e714bc739262140323e08fe2fb9e91e00ee7 (diff)
downloadphp-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.gz
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.zst
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.zip
test: port previously-ignored Composer tests via __ test hatches
Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/repository/repository_factory_test.rs')
-rw-r--r--crates/shirabe/tests/repository/repository_factory_test.rs50
1 files changed, 47 insertions, 3 deletions
diff --git a/crates/shirabe/tests/repository/repository_factory_test.rs b/crates/shirabe/tests/repository/repository_factory_test.rs
index a0eb81f..c018c45 100644
--- a/crates/shirabe/tests/repository/repository_factory_test.rs
+++ b/crates/shirabe/tests/repository/repository_factory_test.rs
@@ -1,13 +1,57 @@
//! ref: composer/tests/Composer/Test/Repository/RepositoryFactoryTest.php
+use std::cell::RefCell;
+use std::rc::Rc;
+
use indexmap::IndexMap;
+use shirabe::config::Config;
+use shirabe::io::IOInterface;
+use shirabe::io::null_io::NullIO;
use shirabe::repository::RepositoryFactory;
+use shirabe::util::http_downloader::HttpDownloader;
use shirabe_php_shim::PhpMixed;
#[test]
-#[ignore = "PHP test uses ReflectionProperty to read the private RepositoryManager::repository_classes field; no public accessor for repository_classes keys exists in the Rust impl"]
+#[ignore]
fn test_manager_with_all_repository_types() {
- todo!()
+ let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new()));
+ let config = Rc::new(RefCell::new(Config::new(false, None)));
+ let http_downloader = Rc::new(RefCell::new(HttpDownloader::new(
+ io.clone(),
+ config.clone(),
+ IndexMap::new(),
+ true,
+ )));
+
+ let manager =
+ RepositoryFactory::manager(io, &config, Some(http_downloader), None, None).unwrap();
+
+ let repository_classes: Vec<&str> = manager
+ .__repository_classes()
+ .keys()
+ .map(|k| k.as_str())
+ .collect();
+
+ assert_eq!(
+ vec![
+ "composer",
+ "vcs",
+ "package",
+ "pear",
+ "git",
+ "bitbucket",
+ "git-bitbucket",
+ "github",
+ "gitlab",
+ "svn",
+ "fossil",
+ "perforce",
+ "hg",
+ "artifact",
+ "path",
+ ],
+ repository_classes
+ );
}
fn generate_repository_name_provider() -> Vec<(
@@ -53,7 +97,7 @@ fn generate_repository_name_provider() -> Vec<(
}
#[test]
-#[ignore = "generate_repository_name does not stringify an integer index (PhpMixed::as_string returns None for Int), so a numeric index with no url yields \"\" instead of e.g. \"0\""]
+#[ignore]
fn test_generate_repository_name() {
for (index, repo_pairs, existing_keys, expected) in generate_repository_name_provider() {
let repo: IndexMap<String, PhpMixed> = repo_pairs