refactor: fix compiler warnings and clippy warnings

4 files changed, 6 insertions, 11 deletions

diff --git a/crates/shirabe/tests/repository/array_repository_test.rs b/crates/shirabe/tests/repository/array_repository_test.rs
index 60bea16..1612b7c 100644
--- a/crates/shirabe/tests/repository/array_repository_test.rs
+++ b/crates/shirabe/tests/repository/array_repository_test.rs
@@ -49,7 +49,7 @@ fn reprs(results: &[SearchResult]) -> Vec<(String, Option<String>, Abandoned)> {
 
 #[test]
 fn test_add_package() {
-    let mut repo = ArrayRepository::new(vec![]).unwrap();
+    let repo = ArrayRepository::new(vec![]).unwrap();
     repo.add_package(get_package("foo", "1")).unwrap();
 
     assert_eq!(1, repo.count().unwrap());
@@ -75,7 +75,7 @@ fn test_remove_package() {
 
 #[test]
 fn test_has_package() {
-    let mut repo = ArrayRepository::new(vec![]).unwrap();
+    let repo = ArrayRepository::new(vec![]).unwrap();
     repo.add_package(get_package("foo", "1")).unwrap();
     repo.add_package(get_package("bar", "2")).unwrap();
 
@@ -102,7 +102,7 @@ fn test_find_packages() {
 #[test]
 #[ignore]
 fn test_automatically_add_aliased_package_but_not_remove() {
-    let mut repo = ArrayRepository::new(vec![]).unwrap();
+    let repo = ArrayRepository::new(vec![]).unwrap();
 
     let package = get_package("foo", "1");
     let alias = get_alias_package(&package, "2");
diff --git a/crates/shirabe/tests/repository/vcs/forgejo_driver_test.rs b/crates/shirabe/tests/repository/vcs/forgejo_driver_test.rs
index 1f9ae53..2e36833 100644
--- a/crates/shirabe/tests/repository/vcs/forgejo_driver_test.rs
+++ b/crates/shirabe/tests/repository/vcs/forgejo_driver_test.rs
@@ -10,7 +10,7 @@ use shirabe::io::null_io::NullIO;
 use shirabe::repository::vcs::ForgejoDriver;
 use shirabe::util::filesystem::Filesystem;
 use shirabe::util::http_downloader::{HttpDownloader, HttpDownloaderMockHandler};
-use shirabe::util::process_executor::{MockHandler, ProcessExecutor};
+use shirabe::util::process_executor::MockHandler;
 use shirabe_php_shim::PhpMixed;
 use tempfile::TempDir;
 
diff --git a/crates/shirabe/tests/repository/vcs/gitlab_driver_test.rs b/crates/shirabe/tests/repository/vcs/gitlab_driver_test.rs
index e21835d..437617b 100644
--- a/crates/shirabe/tests/repository/vcs/gitlab_driver_test.rs
+++ b/crates/shirabe/tests/repository/vcs/gitlab_driver_test.rs
@@ -12,9 +12,7 @@ use shirabe::util::http_downloader::{HttpDownloader, HttpDownloaderMockHandler};
 use shirabe::util::process_executor::{MockHandler, ProcessExecutor};
 use shirabe_php_shim::{PhpMixed, extension_loaded};
 
-use crate::http_downloader_mock::{
-    HttpDownloaderMockGuard, expect, expect_full, get_http_downloader_mock,
-};
+use crate::http_downloader_mock::{HttpDownloaderMockGuard, expect_full, get_http_downloader_mock};
 use crate::process_executor_mock::{ProcessExecutorMockGuard, get_process_executor_mock};
 
 // Mirrors GitLabDriverTest::setUp's `gitlab-domains` configuration.
diff --git a/crates/shirabe/tests/repository/vcs_repository_test.rs b/crates/shirabe/tests/repository/vcs_repository_test.rs
index 279db04..e3b0e84 100644
--- a/crates/shirabe/tests/repository/vcs_repository_test.rs
+++ b/crates/shirabe/tests/repository/vcs_repository_test.rs
@@ -26,10 +26,7 @@ struct SetUp {
 // ref: VcsRepositoryTest::initialize. Builds a fixture git repository on disk by shelling out to
 // git. Returns None when git is unavailable (mirroring markTestSkipped).
 fn set_up() -> Option<SetUp> {
-    if which_git().is_none() {
-        // 'This test needs a git binary in the PATH to be able to run'
-        return None;
-    }
+    which_git()?;
 
     let composer_home = TempDir::new().unwrap();
     let git_repo = TempDir::new().unwrap();