diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
| commit | 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch) | |
| tree | b19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/util/platform_test.rs | |
| parent | 80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff) | |
| download | php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip | |
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each:
25 now pass and had the attribute removed; the remaining 49 got a
concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type
mismatches, config bool-coercion bugs, missing skipped_load wiring
in PoolBuilder, etc.) so future work can find and fix them by grep.
No production code or test logic/assertions were changed.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/util/platform_test.rs')
| -rw-r--r-- | crates/shirabe/tests/util/platform_test.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crates/shirabe/tests/util/platform_test.rs b/crates/shirabe/tests/util/platform_test.rs index c5fe1908..97ab0bbe 100644 --- a/crates/shirabe/tests/util/platform_test.rs +++ b/crates/shirabe/tests/util/platform_test.rs @@ -4,7 +4,9 @@ use shirabe::util::platform::Platform; use shirabe_php_shim::defined; #[test] -#[ignore] +#[ignore = "Preg::replace_callback doesn't set PREG_UNMATCHED_AS_NULL, so the non-participating \ +alternation branch (dvar) is captured as an empty string instead of absent; Platform::expand_path's \ +matches.get(dvar).or_else(pvar) then picks the empty dvar over pvar for the %VAR% form"] fn test_expand_path() { Platform::put_env("TESTENV", "/home/test"); assert_eq!( |