aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/util/stream_context_factory_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
committernsfisis <nsfisis@gmail.com>2026-07-20 16:04:45 +0900
commit37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch)
treeb19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/util/stream_context_factory_test.rs
parent80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff)
downloadphp-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst
php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/util/stream_context_factory_test.rs')
-rw-r--r--crates/shirabe/tests/util/stream_context_factory_test.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/crates/shirabe/tests/util/stream_context_factory_test.rs b/crates/shirabe/tests/util/stream_context_factory_test.rs
index 2ef2b6b7..f9d840cf 100644
--- a/crates/shirabe/tests/util/stream_context_factory_test.rs
+++ b/crates/shirabe/tests/util/stream_context_factory_test.rs
@@ -119,7 +119,7 @@ fn test_get_context() {
#[test]
#[serial_test::serial]
-#[ignore]
+#[ignore = "fix_http_header_field's uasort comparator (ported verbatim, ignores its second argument) is not a valid ordering; Rust's stable sort_by resolves the resulting ties differently than PHP's Zend sort, so the header order diverges from expected"]
fn test_http_proxy() {
let _tear_down = TearDown;
set_up();
@@ -227,7 +227,7 @@ fn test_http_proxy_with_no_proxy_wildcard() {
#[test]
#[serial_test::serial]
-#[ignore]
+#[ignore = "fix_http_header_field's uasort comparator (ported verbatim, ignores its second argument) is not a valid ordering; Rust's stable sort_by resolves the resulting ties differently than PHP's Zend sort, so the header order diverges from expected"]
fn test_options_are_preserved() {
let _tear_down = TearDown;
set_up();
@@ -275,7 +275,7 @@ fn test_options_are_preserved() {
#[test]
#[serial_test::serial]
-#[ignore]
+#[ignore = "fix_http_header_field's uasort comparator (ported verbatim, ignores its second argument) is not a valid ordering; Rust's stable sort_by resolves the resulting ties differently than PHP's Zend sort, so the header order diverges from expected"]
fn test_http_proxy_without_port() {
let _tear_down = TearDown;
set_up();
@@ -418,7 +418,7 @@ fn test_ensure_thatfix_http_header_field_moves_content_type_to_end_of_options()
#[test]
#[serial_test::serial]
-#[ignore]
+#[ignore = "init_options only inserts the 'header' key when 'http' already exists in options; PHP's `$options['http']['header'] = []` auto-vivifies 'http', but the Rust port's `if let Some(PhpMixed::Array(http)) = options.get_mut(\"http\")` guard silently no-ops on an empty options map, leaving 'http' absent"]
fn test_init_options_does_include_proxy_auth_headers() {
let _tear_down = TearDown;
set_up();
@@ -446,7 +446,7 @@ fn test_init_options_does_include_proxy_auth_headers() {
#[test]
#[serial_test::serial]
-#[ignore]
+#[ignore = "init_options only inserts the 'header' key when 'http' already exists in options; PHP's `$options['http']['header'] = []` auto-vivifies 'http', but the Rust port's `if let Some(PhpMixed::Array(http)) = options.get_mut(\"http\")` guard silently no-ops on an empty options map, leaving 'http' absent"]
fn test_init_options_for_curl_does_not_include_proxy_auth_headers() {
let _tear_down = TearDown;
set_up();