diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-22 23:42:07 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-22 23:42:07 +0900 |
| commit | 5ab5f3b316798c1411ce8e6a7f5b091fda93589c (patch) | |
| tree | c7669f94f5d9bd9adc07bc1aab3f14cfdec1ae5f /crates/shirabe/tests/util | |
| parent | b291e714bc739262140323e08fe2fb9e91e00ee7 (diff) | |
| download | php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.gz php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.zst php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.zip | |
test: port previously-ignored Composer tests via __ test hatches
Re-evaluate the reason'd #[ignore] tests under the Phase D criterion:
a test is unportable ONLY if the APIs/types needed to WRITE it do not
exist. A test that compiles but panics at runtime (todo!() body, a
regex the regex crate cannot compile) or fails at runtime (incomplete
or incorrect impl behavior) is portable -- it is written in full and
marked with a reason-less #[ignore].
About 120 test functions move from reason'd #[ignore] to reason-less
#[ignore] (the ported-but-not-yet-passing signal). Impl crates gain
only additive __ test hatches (init_command, pool, file_downloader,
package handle link setters, artifact/path repository, repository
manager, svn); no existing logic changes. Tests whose required APIs
genuinely do not exist (mock/reflection harness, ApplicationTester,
solve() discarding SolverProblemsException, a script::Event that
cannot be passed as an originating event) keep their reason'd
#[ignore].
cargo check -p shirabe --tests passes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/util')
| -rw-r--r-- | crates/shirabe/tests/util/config_validator_test.rs | 8 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/forgejo_url_test.rs | 6 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/http/request_proxy_test.rs | 2 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/ini_helper_test.rs | 15 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/no_proxy_pattern_test.rs | 4 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/package_sorter_test.rs | 38 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/platform_test.rs | 2 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/silencer_test.rs | 2 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/svn_test.rs | 134 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/tar_test.rs | 14 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/url_test.rs | 4 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/zip_test.rs | 16 |
12 files changed, 180 insertions, 65 deletions
diff --git a/crates/shirabe/tests/util/config_validator_test.rs b/crates/shirabe/tests/util/config_validator_test.rs index da962e0..2e4aed0 100644 --- a/crates/shirabe/tests/util/config_validator_test.rs +++ b/crates/shirabe/tests/util/config_validator_test.rs @@ -29,7 +29,7 @@ fn validate(file: &str) -> Vec<String> { /// Test ConfigValidator warns on commit reference #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_commit_ref_warning() { let warnings = validate(&fixture("composer_commit-ref.json")); @@ -39,7 +39,7 @@ fn test_config_validator_commit_ref_warning() { } #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_warns_on_script_description_for_nonexistent_script() { let warnings = validate(&fixture("composer_scripts-descriptions.json")); @@ -52,7 +52,7 @@ fn test_config_validator_warns_on_script_description_for_nonexistent_script() { } #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_warns_on_script_alias_for_nonexistent_script() { let warnings = validate(&fixture("composer_scripts-aliases.json")); @@ -62,7 +62,7 @@ fn test_config_validator_warns_on_script_alias_for_nonexistent_script() { } #[test] -#[ignore = "ConfigValidator::validate reaches a todo!() in the php-shim"] +#[ignore] fn test_config_validator_warns_on_unnecessary_provide_replace() { let warnings = validate(&fixture("composer_provide-replace-requirements.json")); diff --git a/crates/shirabe/tests/util/forgejo_url_test.rs b/crates/shirabe/tests/util/forgejo_url_test.rs index e29c05e..5c33596 100644 --- a/crates/shirabe/tests/util/forgejo_url_test.rs +++ b/crates/shirabe/tests/util/forgejo_url_test.rs @@ -3,7 +3,7 @@ use shirabe::util::forgejo_url::ForgejoUrl; #[test] -#[ignore = "Preg::match panics: ForgejoUrl::URL_REGEX is an undelimited pattern"] +#[ignore] fn test_create() { for repo_url in create_provider() { let forgejo_url = ForgejoUrl::try_from(Some(repo_url)); @@ -29,13 +29,13 @@ fn create_provider() -> Vec<&'static str> { } #[test] -#[ignore = "Preg::match panics: ForgejoUrl::URL_REGEX is an undelimited pattern"] +#[ignore] fn test_create_invalid() { assert!(ForgejoUrl::create("https://example.org").is_err()); } #[test] -#[ignore = "Preg::match panics: ForgejoUrl::URL_REGEX is an undelimited pattern"] +#[ignore] fn test_generate_ssh_url() { let forgejo_url = ForgejoUrl::create("git@codeberg.org:acme/repo.git").unwrap(); diff --git a/crates/shirabe/tests/util/http/request_proxy_test.rs b/crates/shirabe/tests/util/http/request_proxy_test.rs index 502ec31..3e96a7b 100644 --- a/crates/shirabe/tests/util/http/request_proxy_test.rs +++ b/crates/shirabe/tests/util/http/request_proxy_test.rs @@ -128,7 +128,7 @@ fn test_get_curl_options() { } #[test] -#[ignore = "secure proxies require curl_version, which is a todo!() in the php-shim"] +#[ignore] fn test_get_curl_options_with_ssl() { let mut cafile_opts: IndexMap<String, PhpMixed> = IndexMap::new(); cafile_opts.insert( diff --git a/crates/shirabe/tests/util/ini_helper_test.rs b/crates/shirabe/tests/util/ini_helper_test.rs index 59dc967..f511d76 100644 --- a/crates/shirabe/tests/util/ini_helper_test.rs +++ b/crates/shirabe/tests/util/ini_helper_test.rs @@ -7,10 +7,11 @@ use shirabe_php_shim::{PATH_SEPARATOR, getenv, putenv}; #[allow(dead_code)] fn set_up() -> TearDown { // Register our name with XdebugHandler. - // TODO: XdebugHandler is the external composer/xdebug-handler package and is not ported. - todo!(); + // The PHP test constructs `new XdebugHandler('composer')` so that + // getAllIniFiles() reads the COMPOSER_ORIGINAL_INIS env var. The Rust + // XdebugHandler is a unit struct with no name-registration API, so this + // step is a no-op here. // Save current state - #[allow(unreachable_code)] let env_original = getenv("COMPOSER_ORIGINAL_INIS"); TearDown { env_original } } @@ -44,7 +45,7 @@ fn set_env(paths: &[&str]) { } #[test] -#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"] +#[ignore] fn test_with_no_ini() { let paths = [""]; @@ -57,7 +58,7 @@ fn test_with_no_ini() { } #[test] -#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"] +#[ignore] fn test_with_loaded_ini_only() { let paths = ["loaded.ini"]; @@ -66,7 +67,7 @@ fn test_with_loaded_ini_only() { } #[test] -#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"] +#[ignore] fn test_with_loaded_ini_and_additional() { let paths = ["loaded.ini", "one.ini", "two.ini"]; @@ -79,7 +80,7 @@ fn test_with_loaded_ini_and_additional() { } #[test] -#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"] +#[ignore] fn test_without_loaded_ini_and_additional() { let paths = ["", "one.ini", "two.ini"]; diff --git a/crates/shirabe/tests/util/no_proxy_pattern_test.rs b/crates/shirabe/tests/util/no_proxy_pattern_test.rs index 7a423b9..51017ea 100644 --- a/crates/shirabe/tests/util/no_proxy_pattern_test.rs +++ b/crates/shirabe/tests/util/no_proxy_pattern_test.rs @@ -42,7 +42,7 @@ fn test_host_name() { } #[test] -#[ignore = "NoProxyPattern does not match IPv4-mapped IPv6 addresses against IPv4 rules (port logic gap)"] +#[ignore] fn test_ip_address() { let noproxy = "192.168.1.1, 2001:db8::52:0:1"; @@ -55,7 +55,7 @@ fn test_ip_address() { } #[test] -#[ignore = "NoProxyPattern does not match IPv4-mapped IPv6 addresses against IPv4/CIDR rules (port logic gap)"] +#[ignore] fn test_ip_range() { let noproxy = "10.0.0.0/30, 2002:db8:a::45/121"; diff --git a/crates/shirabe/tests/util/package_sorter_test.rs b/crates/shirabe/tests/util/package_sorter_test.rs index f84ff09..0a8d395 100644 --- a/crates/shirabe/tests/util/package_sorter_test.rs +++ b/crates/shirabe/tests/util/package_sorter_test.rs @@ -1,30 +1,30 @@ //! ref: composer/tests/Composer/Test/Util/PackageSorterTest.php use indexmap::IndexMap; -use shirabe::package::handle::PackageInterfaceHandle; -use shirabe::package::loader::array_loader::ArrayLoader; +use shirabe::package::Link; +use shirabe::package::handle::{PackageHandle, PackageInterfaceHandle}; use shirabe::util::package_sorter::PackageSorter; -use shirabe_php_shim::PhpMixed; +use shirabe_semver::constraint::MatchAllConstraint; -/// PHP `createPackage` sets requires directly on a `Package`; the public handle API only allows -/// link setters on root packages, so the equivalent here builds the package through ArrayLoader. fn create_package(name: &str, requires: &[&str]) -> PackageInterfaceHandle { - let mut config: IndexMap<String, PhpMixed> = IndexMap::new(); - config.insert("name".to_string(), PhpMixed::String(name.to_string())); - config.insert("version".to_string(), PhpMixed::String("1.0.0".to_string())); + let package = PackageHandle::new(name.to_string(), "1.0.0.0".to_string(), "1.0.0".to_string()); - if !requires.is_empty() { - let mut links: IndexMap<String, PhpMixed> = IndexMap::new(); - for require_name in requires { - links.insert(require_name.to_string(), PhpMixed::String("*".to_string())); - } - config.insert("require".to_string(), PhpMixed::Array(links)); + let mut links: IndexMap<String, Link> = IndexMap::new(); + for require_name in requires { + links.insert( + require_name.to_string(), + Link::new( + package.get_name(), + require_name.to_string(), + MatchAllConstraint::new(None).into(), + None, + "*".to_string(), + ), + ); } + package.__set_requires(links); - ArrayLoader::new(None, false) - .load_packages(vec![config]) - .unwrap() - .remove(0) + package.into() } fn names(packages: &[PackageInterfaceHandle]) -> Vec<String> { @@ -141,7 +141,7 @@ fn sorting_orders_dependencies_higher_than_package_cases() -> Vec<( } #[test] -#[ignore = "constraint parsing reaches a look-around regex unsupported by the regex-crate shim (Preg)"] +#[ignore] fn test_sorting_orders_dependencies_higher_than_package() { for (packages, expected_ordered_list, weights) in sorting_orders_dependencies_higher_than_package_cases() diff --git a/crates/shirabe/tests/util/platform_test.rs b/crates/shirabe/tests/util/platform_test.rs index 626e358..c5fe190 100644 --- a/crates/shirabe/tests/util/platform_test.rs +++ b/crates/shirabe/tests/util/platform_test.rs @@ -4,7 +4,7 @@ use shirabe::util::platform::Platform; use shirabe_php_shim::defined; #[test] -#[ignore = "Platform::expand_path does not read the env var set via put_env in this runtime"] +#[ignore] fn test_expand_path() { Platform::put_env("TESTENV", "/home/test"); assert_eq!( diff --git a/crates/shirabe/tests/util/silencer_test.rs b/crates/shirabe/tests/util/silencer_test.rs index 88d33c6..1b65324 100644 --- a/crates/shirabe/tests/util/silencer_test.rs +++ b/crates/shirabe/tests/util/silencer_test.rs @@ -7,7 +7,7 @@ use shirabe_php_shim::{ /// Test succeeds when no warnings are emitted externally, and original level is restored. #[test] -#[ignore = "trigger_error is todo!() in the php-shim"] +#[ignore] fn test_silencer() { let before = error_reporting(None); diff --git a/crates/shirabe/tests/util/svn_test.rs b/crates/shirabe/tests/util/svn_test.rs index 90a6b45..25e3f4e 100644 --- a/crates/shirabe/tests/util/svn_test.rs +++ b/crates/shirabe/tests/util/svn_test.rs @@ -1,31 +1,145 @@ //! ref: composer/tests/Composer/Test/Util/SvnTest.php -#[ignore = "Svn::get_credential_args is pub(crate) (crate-private); unreachable from an integration test"] +use std::cell::RefCell; +use std::rc::Rc; + +use indexmap::IndexMap; +use shirabe::config::Config; +use shirabe::io::IOInterface; +use shirabe::io::null_io::NullIO; +use shirabe::util::svn::Svn; +use shirabe_php_shim::PhpMixed; + +fn map(pairs: Vec<(&str, PhpMixed)>) -> IndexMap<String, PhpMixed> { + pairs.into_iter().map(|(k, v)| (k.to_string(), v)).collect() +} + +/// Builds a `['config' => ['http-basic' => [host => ['username' => .., 'password' => ..]]]]` +/// map for `Config::merge`. +fn http_basic_config(host: &str, username: &str, password: &str) -> IndexMap<String, PhpMixed> { + let creds = map(vec![ + ("username", PhpMixed::String(username.to_string())), + ("password", PhpMixed::String(password.to_string())), + ]); + let http_basic = map(vec![(host, PhpMixed::Array(creds))]); + let config = map(vec![("http-basic", PhpMixed::Array(http_basic))]); + map(vec![("config", PhpMixed::Array(config))]) +} + +/// ref: SvnTest::urlProvider +fn url_provider() -> Vec<(&'static str, Vec<&'static str>)> { + vec![ + ( + "http://till:test@svn.example.org/", + vec!["--username", "till", "--password", "test"], + ), + ("http://svn.apache.org/", vec![]), + ( + "svn://johndoe@example.org", + vec!["--username", "johndoe", "--password", ""], + ), + ] +} + #[test] +#[ignore] fn test_credentials() { - todo!() + for (url, expect) in url_provider() { + let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new())); + let config = Rc::new(RefCell::new(Config::new(true, None))); + let mut svn = Svn::new(url.to_string(), io, config, None); + + let expect: Vec<String> = expect.iter().map(|s| s.to_string()).collect(); + assert_eq!(expect, svn.__get_credential_args()); + } } -#[ignore = "Svn::get_command is pub(crate) (crate-private); unreachable from an integration test"] #[test] +#[ignore] fn test_interactive_string() { - todo!() + let url = "http://svn.example.org"; + + let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new())); + let config = Rc::new(RefCell::new(Config::new(true, None))); + let mut svn = Svn::new(url.to_string(), io, config, None); + + assert_eq!( + vec![ + "svn".to_string(), + "ls".to_string(), + "--non-interactive".to_string(), + "--".to_string(), + "http://svn.example.org".to_string(), + ], + svn.__get_command(vec!["svn".to_string(), "ls".to_string()], url, None) + ); } -#[ignore = "Svn::get_credential_args is pub(crate) (crate-private); unreachable from an integration test"] #[test] +#[ignore] fn test_credentials_from_config() { - todo!() + let url = "http://svn.apache.org"; + + let mut config = Config::new(true, None); + config.merge(&http_basic_config("svn.apache.org", "foo", "bar"), "test"); + + let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new())); + let mut svn = Svn::new(url.to_string(), io, Rc::new(RefCell::new(config)), None); + + assert_eq!( + vec![ + "--username".to_string(), + "foo".to_string(), + "--password".to_string(), + "bar".to_string(), + ], + svn.__get_credential_args() + ); } -#[ignore = "Svn::get_credential_args is pub(crate) (crate-private); unreachable from an integration test"] #[test] +#[ignore] fn test_credentials_from_config_with_cache_credentials_true() { - todo!() + let url = "http://svn.apache.org"; + + let mut config = Config::new(true, None); + config.merge(&http_basic_config("svn.apache.org", "foo", "bar"), "test"); + + let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new())); + let mut svn = Svn::new(url.to_string(), io, Rc::new(RefCell::new(config)), None); + svn.set_cache_credentials(true); + + assert_eq!( + vec![ + "--username".to_string(), + "foo".to_string(), + "--password".to_string(), + "bar".to_string(), + ], + svn.__get_credential_args() + ); } -#[ignore = "Svn::get_credential_args is pub(crate) (crate-private); unreachable from an integration test"] #[test] +#[ignore] fn test_credentials_from_config_with_cache_credentials_false() { - todo!() + let url = "http://svn.apache.org"; + + let mut config = Config::new(true, None); + config.merge(&http_basic_config("svn.apache.org", "foo", "bar"), "test"); + + let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new())); + let mut svn = Svn::new(url.to_string(), io, Rc::new(RefCell::new(config)), None); + svn.set_cache_credentials(false); + + assert_eq!( + vec![ + "--no-auth-cache".to_string(), + "--username".to_string(), + "foo".to_string(), + "--password".to_string(), + "bar".to_string(), + ], + svn.__get_credential_args() + ); } diff --git a/crates/shirabe/tests/util/tar_test.rs b/crates/shirabe/tests/util/tar_test.rs index 6234108..48f1cbe 100644 --- a/crates/shirabe/tests/util/tar_test.rs +++ b/crates/shirabe/tests/util/tar_test.rs @@ -12,7 +12,7 @@ fn fixture(name: &str) -> String { } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_returns_nullif_the_tar_is_not_found() { let result = Tar::get_composer_json(&fixture("invalid.zip")).unwrap(); @@ -20,26 +20,26 @@ fn test_returns_nullif_the_tar_is_not_found() { } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_returns_null_if_the_tar_is_empty() { let result = Tar::get_composer_json(&fixture("empty.tar.gz")).unwrap(); assert_eq!(None, result); } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_throws_exception_if_the_tar_has_no_composer_json() { assert!(Tar::get_composer_json(&fixture("nojson.tar.gz")).is_err()); } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_throws_exception_if_the_composer_json_is_in_a_sub_subfolder() { assert!(Tar::get_composer_json(&fixture("subfolders.tar.gz")).is_err()); } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_returns_composer_json_in_tar_root() { let result = Tar::get_composer_json(&fixture("root.tar.gz")).unwrap(); assert_eq!( @@ -49,7 +49,7 @@ fn test_returns_composer_json_in_tar_root() { } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_returns_composer_json_in_first_folder() { let result = Tar::get_composer_json(&fixture("folder.tar.gz")).unwrap(); assert_eq!( @@ -59,7 +59,7 @@ fn test_returns_composer_json_in_first_folder() { } #[test] -#[ignore = "PharData::new is todo!() in the php-shim"] +#[ignore] fn test_multiple_top_level_dirs_is_invalid() { assert!(Tar::get_composer_json(&fixture("multiple.tar.gz")).is_err()); } diff --git a/crates/shirabe/tests/util/url_test.rs b/crates/shirabe/tests/util/url_test.rs index cbbfb64..4adb4f2 100644 --- a/crates/shirabe/tests/util/url_test.rs +++ b/crates/shirabe/tests/util/url_test.rs @@ -22,7 +22,7 @@ fn conf(entries: &[(&str, &[&str])]) -> IndexMap<String, PhpMixed> { } #[test] -#[ignore = "update_dist_reference uses a regex pattern the regex crate cannot compile"] +#[ignore] fn test_update_dist_reference() { for (url, expected_url, c, r#ref) in dist_refs_provider() { let mut config = Config::new(true, None); @@ -143,7 +143,7 @@ fn dist_refs_provider() -> Vec<( } #[test] -#[ignore = "Url::sanitize uses a regex pattern the regex crate cannot compile"] +#[ignore] fn test_sanitize() { for (expected, url) in sanitize_provider() { assert_eq!(expected, Url::sanitize(url.to_string())); diff --git a/crates/shirabe/tests/util/zip_test.rs b/crates/shirabe/tests/util/zip_test.rs index b80dd17..4d883e0 100644 --- a/crates/shirabe/tests/util/zip_test.rs +++ b/crates/shirabe/tests/util/zip_test.rs @@ -18,7 +18,7 @@ fn test_throws_exception_if_zip_extension_is_not_loaded() { } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_returns_nullif_the_zip_is_not_found() { let result = Zip::get_composer_json(&fixture("invalid.zip")).unwrap(); @@ -26,7 +26,7 @@ fn test_returns_nullif_the_zip_is_not_found() { } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_returns_null_if_the_zip_is_empty() { let result = Zip::get_composer_json(&fixture("empty.zip")).unwrap(); @@ -34,19 +34,19 @@ fn test_returns_null_if_the_zip_is_empty() { } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_throws_exception_if_the_zip_has_no_composer_json() { assert!(Zip::get_composer_json(&fixture("nojson.zip")).is_err()); } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_throws_exception_if_the_composer_json_is_in_a_sub_subfolder() { assert!(Zip::get_composer_json(&fixture("subfolders.zip")).is_err()); } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_returns_composer_json_in_zip_root() { let result = Zip::get_composer_json(&fixture("root.zip")).unwrap(); @@ -57,7 +57,7 @@ fn test_returns_composer_json_in_zip_root() { } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_returns_composer_json_in_first_folder() { let result = Zip::get_composer_json(&fixture("folder.zip")).unwrap(); @@ -68,13 +68,13 @@ fn test_returns_composer_json_in_first_folder() { } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_multiple_top_level_dirs_is_invalid() { assert!(Zip::get_composer_json(&fixture("multiple.zip")).is_err()); } #[test] -#[ignore = "ZipArchive::new is todo!() in the php-shim"] +#[ignore] fn test_returns_composer_json_from_first_subfolder() { let result = Zip::get_composer_json(&fixture("single-sub.zip")).unwrap(); |
