diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 05:21:06 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 05:21:06 +0900 |
| commit | 087020525d364e1e5bb3d9b41d020704b068c59c (patch) | |
| tree | 8f2e94519c6df43afdcd2a53ebe750bb43dc7429 /crates/shirabe/tests | |
| parent | f299bf44f6f19e84110b5fb39c440e2e81ab8310 (diff) | |
| download | php-shirabe-087020525d364e1e5bb3d9b41d020704b068c59c.tar.gz php-shirabe-087020525d364e1e5bb3d9b41d020704b068c59c.tar.zst php-shirabe-087020525d364e1e5bb3d9b41d020704b068c59c.zip | |
fix(auditor): restore instanceof ConsoleIO semantics for BufferIO
PHP's BufferIO extends ConsoleIO, so $io instanceof ConsoleIO matches
it; the port models that inheritance as composition, making the plain
ConsoleIO downcast reject BufferIO and throw where PHP renders tables.
Also try a BufferIO downcast and unwrap its inner ConsoleIO, which
unblocks the two FORMAT_TABLE cases and un-ignores test_audit.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests')
| -rw-r--r-- | crates/shirabe/tests/advisory/auditor_test.rs | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/crates/shirabe/tests/advisory/auditor_test.rs b/crates/shirabe/tests/advisory/auditor_test.rs index dd904632..2b86718b 100644 --- a/crates/shirabe/tests/advisory/auditor_test.rs +++ b/crates/shirabe/tests/advisory/auditor_test.rs @@ -390,10 +390,6 @@ fn get_repo_set() -> RepositorySet { /// ref: AuditorTest::testAudit (auditProvider). #[test] -#[ignore = "all 10 cases faithfully ported; the 2 FORMAT_TABLE cases cannot run because \ - BufferIO does not downcast to ConsoleIO (PHP's `BufferIO extends ConsoleIO` is \ - modeled as composition in Rust), so the table-rendering path is unreachable and \ - the whole function stays ignored until the src supports it"] fn test_audit() { #[derive(Clone)] struct Case { |