aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-28 07:16:42 +0900
committernsfisis <nsfisis@gmail.com>2026-06-28 07:20:32 +0900
commit0bf96f5de11555ddfdcde81c0a27869afeaf5832 (patch)
treef44aa2e365dec17b532b784667ba836d734857e8 /crates/shirabe/tests
parentf74d43409220ac209d01367bfc40dbc2c85be252 (diff)
downloadphp-shirabe-0bf96f5de11555ddfdcde81c0a27869afeaf5832.tar.gz
php-shirabe-0bf96f5de11555ddfdcde81c0a27869afeaf5832.tar.zst
php-shirabe-0bf96f5de11555ddfdcde81c0a27869afeaf5832.zip
test(console): correct inaccurate test skip reasons
setCatchErrors is an old-Symfony compatibility shim that exists in neither Composer's PHP class nor Shirabe, and setAutoExit(false) is the default in Shirabe, so neither is a reason a test is unportable. Drop those mentions and point the application_test ignores at the real blocker: do_run's script-command registration is still a todo!(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests')
-rw-r--r--crates/shirabe/tests/application_test.rs9
-rw-r--r--crates/shirabe/tests/documentation_test.rs2
2 files changed, 5 insertions, 6 deletions
diff --git a/crates/shirabe/tests/application_test.rs b/crates/shirabe/tests/application_test.rs
index 5a34316..d54f43b 100644
--- a/crates/shirabe/tests/application_test.rs
+++ b/crates/shirabe/tests/application_test.rs
@@ -1,8 +1,9 @@
//! ref: composer/tests/Composer/Test/ApplicationTest.php
// These drive the console Application (doRun, command resolution, plugin disabling).
-// The tests needing Application::setAutoExit/setCatchErrors or the initTempComposer
-// helper, or a runtime define() of COMPOSER_DEV_WARNING_TIME, remain unportable.
+// The tests exercising do_run's script-command registration (a todo!() pending the
+// Symfony command-registry model), or a runtime define() of COMPOSER_DEV_WARNING_TIME,
+// remain unportable.
use std::cell::RefCell;
use std::rc::Rc;
@@ -108,7 +109,7 @@ fn test_process_isolation_works_multiple_times() {
assert_eq!(0, application.do_run(input2, output2).unwrap());
}
-#[ignore = "Application::set_auto_exit / set_catch_errors and the initTempComposer test helper do not exist"]
+#[ignore = "do_run's script-command registration is a todo!() pending the Symfony command-registry model"]
#[test]
fn test_no_plugins_disables_plugins_when_script_commands_exist() {
let _tear_down = TearDown;
@@ -117,7 +118,7 @@ fn test_no_plugins_disables_plugins_when_script_commands_exist() {
todo!()
}
-#[ignore = "Application::set_auto_exit / set_catch_errors and the initTempComposer test helper do not exist"]
+#[ignore = "do_run's script-command registration is a todo!() pending the Symfony command-registry model"]
#[test]
fn test_script_command_takes_priority_over_abbreviated_builtin_command() {
let _tear_down = TearDown;
diff --git a/crates/shirabe/tests/documentation_test.rs b/crates/shirabe/tests/documentation_test.rs
index 07694d8..4fe9a94 100644
--- a/crates/shirabe/tests/documentation_test.rs
+++ b/crates/shirabe/tests/documentation_test.rs
@@ -18,8 +18,6 @@ fn get_command_name(command: &Rc<RefCell<dyn Command>>) -> String {
fn provide_command_cases() -> Vec<Rc<RefCell<dyn Command>>> {
let application = ApplicationHandle::new("Composer".to_string(), "".to_string()).unwrap();
- // setAutoExit(false) is the default in Shirabe. The setCatchErrors() call is guarded by
- // method_exists() in PHP and has no Rust equivalent.
application.set_catch_exceptions(false);
let mut description =