aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-21 19:38:05 +0900
committernsfisis <nsfisis@gmail.com>2026-06-21 19:39:05 +0900
commit26bd490e6f9dc8476bc2cc9902f18692d8715df4 (patch)
tree0c56c840527aa279fdcfda24a8aa79072ba0dec7 /crates/shirabe
parent1deb0b88edd455142160c0a03c094422907f2df6 (diff)
downloadphp-shirabe-26bd490e6f9dc8476bc2cc9902f18692d8715df4.tar.gz
php-shirabe-26bd490e6f9dc8476bc2cc9902f18692d8715df4.tar.zst
php-shirabe-26bd490e6f9dc8476bc2cc9902f18692d8715df4.zip
feat(php-shim): implement microtime
Drop the get_as_float parameter; the Rust shim always returns f64. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe')
-rw-r--r--crates/shirabe/src/console/application.rs4
-rw-r--r--crates/shirabe/src/dependency_resolver/pool_builder.rs8
-rw-r--r--crates/shirabe/src/dependency_resolver/solver.rs4
-rw-r--r--crates/shirabe/src/io/console_io.rs2
-rw-r--r--crates/shirabe/tests/util/silencer_test.rs3
5 files changed, 10 insertions, 11 deletions
diff --git a/crates/shirabe/src/console/application.rs b/crates/shirabe/src/console/application.rs
index 94f904f..01515a1 100644
--- a/crates/shirabe/src/console/application.rs
+++ b/crates/shirabe/src/console/application.rs
@@ -911,7 +911,7 @@ impl Application {
.borrow()
.has_parameter_option(PhpMixed::from(vec!["--profile"]), false)
{
- start_time = Some(microtime(true));
+ start_time = Some(microtime());
// PHP: $this->io->enableDebugging($startTime).
// TODO(phase-c): enableDebugging exists only on ConsoleIO, not on IOInterface,
// and self.io is still the NullIO because the ConsoleIO construction above is
@@ -951,7 +951,7 @@ impl Application {
"<info>Memory usage: {}MiB (peak: {}MiB), time: {}s</info>",
round((memory_get_usage() as f64) / 1024.0 / 1024.0, 2),
round((memory_get_peak_usage(false) as f64) / 1024.0 / 1024.0, 2),
- round(microtime(true) - st, 2)
+ round(microtime() - st, 2)
));
}
diff --git a/crates/shirabe/src/dependency_resolver/pool_builder.rs b/crates/shirabe/src/dependency_resolver/pool_builder.rs
index 9b4c561..c2e328b 100644
--- a/crates/shirabe/src/dependency_resolver/pool_builder.rs
+++ b/crates/shirabe/src/dependency_resolver/pool_builder.rs
@@ -1060,7 +1060,7 @@ impl PoolBuilder {
self.io.debug("Running pool optimizer.", &[]);
- let before = microtime(true);
+ let before = microtime();
let total = pool.get_packages().len() as f64;
let pool = self
@@ -1078,7 +1078,7 @@ impl PoolBuilder {
self.io.write3(
&format!(
"Pool optimizer completed in {:.3} seconds",
- (microtime(true) - before),
+ (microtime() - before),
),
true,
io_interface::VERY_VERBOSE,
@@ -1109,7 +1109,7 @@ impl PoolBuilder {
self.io.debug("Running security advisory pool filter.", &[]);
- let before = microtime(true);
+ let before = microtime();
let total = pool.get_packages().len() as f64;
let repos_owned: Vec<RepositoryInterfaceHandle> = repositories.to_vec();
@@ -1128,7 +1128,7 @@ impl PoolBuilder {
self.io.write3(
&format!(
"Security advisory pool filter completed in {:.3} seconds",
- (microtime(true) - before),
+ (microtime() - before),
),
true,
io_interface::VERY_VERBOSE,
diff --git a/crates/shirabe/src/dependency_resolver/solver.rs b/crates/shirabe/src/dependency_resolver/solver.rs
index d6654a9..52c4580 100644
--- a/crates/shirabe/src/dependency_resolver/solver.rs
+++ b/crates/shirabe/src/dependency_resolver/solver.rs
@@ -259,13 +259,13 @@ impl Solver {
self.io
.write_error3("Resolving dependencies through SAT", true, crate::io::DEBUG);
- let before = microtime(true);
+ let before = microtime();
self.run_sat()?;
self.io.write_error3("", true, crate::io::DEBUG);
self.io.write_error3(
&format!(
"Dependency resolution completed in {:.3} seconds",
- microtime(true) - before,
+ microtime() - before,
),
true,
crate::io::VERBOSE,
diff --git a/crates/shirabe/src/io/console_io.rs b/crates/shirabe/src/io/console_io.rs
index 25ec02d..e6261c7 100644
--- a/crates/shirabe/src/io/console_io.rs
+++ b/crates/shirabe/src/io/console_io.rs
@@ -96,7 +96,7 @@ impl ConsoleIO {
let messages = if let Some(start_time) = self.start_time {
let memory_usage = (shirabe_php_shim::memory_get_usage() as f64) / 1024.0 / 1024.0;
- let time_spent = microtime(true) - start_time;
+ let time_spent = microtime() - start_time;
// PHP: array_map(fn ($message): string => sprintf(...), (array) $messages)
let arr: Vec<String> = match &messages {
PhpMixed::String(s) => vec![s.clone()],
diff --git a/crates/shirabe/tests/util/silencer_test.rs b/crates/shirabe/tests/util/silencer_test.rs
index c4e3baa..88d33c6 100644
--- a/crates/shirabe/tests/util/silencer_test.rs
+++ b/crates/shirabe/tests/util/silencer_test.rs
@@ -32,9 +32,8 @@ fn test_silencer() {
/// Test whether exception from silent callbacks are correctly forwarded.
#[test]
-#[ignore = "microtime is todo!() in the php-shim"]
fn test_silenced_exception() {
- let verification = format!("{}", microtime(false));
+ let verification = format!("{}", microtime());
let err = Silencer::call(|| -> anyhow::Result<()> {
Err(RuntimeException {
message: verification.clone(),